third_party/WebKit/Source/bindings/core/v8/SourceLocation.h - Issue 2004243002: Migrate websockets from url+lineNumber to SourceLocation.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/core/v8/SourceLocation.h

Issue 2004243002: Migrate websockets from url+lineNumber to SourceLocation. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@more-source-location-1

Patch Set: rebased Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | third_party/WebKit/Source/bindings/core/v8/SourceLocation.cpp » ('j') | third_party/WebKit/Source/modules/websockets/WorkerWebSocketChannel.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/bindings/core/v8/SourceLocation.h

diff --git a/third_party/WebKit/Source/bindings/core/v8/SourceLocation.h b/third_party/WebKit/Source/bindings/core/v8/SourceLocation.h

index c441b351803a9edf60c6f8661c20223927c66ba3..fb8362df5170cee39f53e8ba5fa36b4cb36ca462 100644

--- a/third_party/WebKit/Source/bindings/core/v8/SourceLocation.h

+++ b/third_party/WebKit/Source/bindings/core/v8/SourceLocation.h

@@ -28,12 +28,14 @@ public:

static PassOwnPtr<SourceLocation> create(const String& url, unsigned lineNumber, unsigned columnNumber, PassOwnPtr<V8StackTrace>, int scriptId = 0);

~SourceLocation();

+ bool isEmpty() const { return m_url.isNull(); }

String url() const { return m_url; }

unsigned lineNumber() const { return m_lineNumber; }

unsigned columnNumber() const { return m_columnNumber; }

PassOwnPtr<V8StackTrace> takeStackTrace() { return std::move(m_stackTrace); }

int scriptId() const { return m_scriptId; }

void toTracedValue(TracedValue*, const char* name) const;

+ PassOwnPtr<SourceLocation> clone() const;

private:

SourceLocation(const String& url, unsigned lineNumber, unsigned columnNumber, PassOwnPtr<V8StackTrace>, int scriptId);