third_party/WebKit/Source/bindings/core/v8/SourceLocation.cpp - Issue 2004243002: Migrate websockets from url+lineNumber to SourceLocation.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/Source/bindings/core/v8/SourceLocation.cpp

Issue 2004243002: Migrate websockets from url+lineNumber to SourceLocation. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@more-source-location-1

Patch Set: rebased Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « third_party/WebKit/Source/bindings/core/v8/SourceLocation.h ('k') | third_party/WebKit/Source/modules/websockets/DOMWebSocket.cpp » ('j') | third_party/WebKit/Source/modules/websockets/WorkerWebSocketChannel.cpp » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright 2016 The Chromium Authors. All rights reserved.	1 // Copyright 2016 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include "bindings/core/v8/SourceLocation.h"	5 #include "bindings/core/v8/SourceLocation.h"

6	6

7 #include "bindings/core/v8/V8PerIsolateData.h"	7 #include "bindings/core/v8/V8PerIsolateData.h"

8 #include "core/dom/Document.h"	8 #include "core/dom/Document.h"

9 #include "core/dom/ExecutionContext.h"	9 #include "core/dom/ExecutionContext.h"

10 #include "core/dom/ScriptableDocumentParser.h"	10 #include "core/dom/ScriptableDocumentParser.h"

(...skipping 81 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
92 value->beginDictionary();	92 value->beginDictionary();

93 value->setString("functionName", m_stackTrace->topFunctionName());	93 value->setString("functionName", m_stackTrace->topFunctionName());

94 value->setString("scriptId", m_stackTrace->topScriptId());	94 value->setString("scriptId", m_stackTrace->topScriptId());

95 value->setString("url", m_stackTrace->topSourceURL());	95 value->setString("url", m_stackTrace->topSourceURL());

96 value->setInteger("lineNumber", m_stackTrace->topLineNumber());	96 value->setInteger("lineNumber", m_stackTrace->topLineNumber());

97 value->setInteger("columnNumber", m_stackTrace->topColumnNumber());	97 value->setInteger("columnNumber", m_stackTrace->topColumnNumber());

98 value->endDictionary();	98 value->endDictionary();

99 value->endArray();	99 value->endArray();

100 }	100 }

101	101

	102 PassOwnPtr<SourceLocation> SourceLocation::clone() const

	103 {

	104 return adoptPtr(new SourceLocation(m_url, m_lineNumber, m_columnNumber, m_st ackTrace ? m_stackTrace->clone() : nullptr, m_scriptId));

	105 }

	106

102 } // namespace blink	107 } // namespace blink

OLD	NEW