DevTools: Extend Runtime.CallArgument to pass numbers that can not be JSON-stringified.

Source/devtools/front_end/RemoteObject.js

 /*
  * Copyright (C) 2009 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 196 matching lines @@
         // handle
         this._objectId = objectId;
         this._description = description;
         this._hasChildren = true;
         this._preview = preview;
     } else {
         // Primitive or null object.
         console.assert(type !== "object" || value === null);
         this._description = description || (value + "");
         this._hasChildren = false;
-        this.value = value;
+        // Handle special numbers: NaN, Infinity, -Infinity, -0.
+        if (type === "number" && typeof value !== "number")
+            this.value = Number(value);
+        else
+            this.value = value;
     }
 }
 
 WebInspector.RemoteObjectImpl.prototype = {
     /** @return {!RuntimeAgent.RemoteObjectId} */
     get objectId()
     {
         return this._objectId;
     },
 
@@ skipping 150 matching lines @@
      * @param {function(string=)} callback
      */
     doSetObjectPropertyValue: function(result, name, callback)
     {
         // This assignment may be for a regular (data) property, and for an acccessor property (with getter/setter).
         // Note the sensitive matter about accessor property: the property may be physically defined in some proto object,
         // but logically it is bound to the object in question. JavaScript passes this object to getters/setters, not the object
         // where property was defined; so do we.
         var setPropertyValueFunction = "function(a, b) { this[a] = b; }";
 
-        // Special case for NaN, Infinity, -Infinity, -0.
-        if (result.type === "number" && String(result.value) !== result.description)
-            setPropertyValueFunction = "function(a) { this[a] = " + result.description + "; }";
-
-        delete result.description; // Optimize on traffic.
-        this._runtimeAgent.callFunctionOn(this._objectId, setPropertyValueFunction, [{ value:name }, result], true, undefined, undefined, propertySetCallback.bind(this));
+        var argv = [{ value: name }, this._toCallArgument(result)]
+        this._runtimeAgent.callFunctionOn(this._objectId, setPropertyValueFunction, argv, true, undefined, undefined, propertySetCallback.bind(this));
 
         /**
          * @param {?Protocol.Error} error
          * @param {!RuntimeAgent.RemoteObject} result
          * @param {boolean=} wasThrown
          */
         function propertySetCallback(error, result, wasThrown)
         {
             if (error || wasThrown) {
                 callback(error || result.description);
                 return;
             }
             callback();
         }
     },
 
     /**
+     * @param {!RuntimeAgent.RemoteObject} object
+     * @return {!RuntimeAgent.CallArgument}
+     */
+    _toCallArgument: function(object)
+    {
+        return { value: object.value, objectId: object.objectId, type: /** @type {!RuntimeAgent.CallArgumentType.<string>} */ (object.type) };
+    },
+
+    /**
      * @param {function(?DOMAgent.NodeId)} callback
      */
     pushNodeToFrontend: function(callback)
     {
         if (this._objectId)
             this._domAgent.pushNodeToFrontend(this._objectId, callback);
         else
             callback(0);
     },
 
@@ skipping 217 matching lines @@
     },
 
     /**
      * @override
      * @param {!RuntimeAgent.RemoteObject} result
      * @param {string} name
      * @param {function(string=)} callback
      */
     doSetObjectPropertyValue: function(result, name, callback)
     {
-        var newValue;
-
-        switch (result.type) {
-            case "undefined":
-                newValue = {};
-                break;
-            case "object":
-            case "function":
-                newValue = { objectId: result.objectId };
-                break;
-            default:
-                newValue = { value: result.value };
-        }
-
-        this._debuggerAgent.setVariableValue(this._scopeRef.number, name, newValue, this._scopeRef.callFrameId, this._scopeRef.functionId, setVariableValueCallback.bind(this));
+        this._debuggerAgent.setVariableValue(this._scopeRef.number, name, this._toCallArgument(result), this._scopeRef.callFrameId, this._scopeRef.functionId, setVariableValueCallback.bind(this));
 
         /**
          * @param {?Protocol.Error} error
          * @this {WebInspector.ScopeRemoteObject}
          */
         function setVariableValueCallback(error)
         {
             if (error) {
                 callback(error);
                 return;
@@ skipping 305 matching lines @@
             result = functionDeclaration.apply(target, rawArgs);
         } catch (e) {
             result = null;
         }
 
         callback(result);
     },
 
     __proto__: WebInspector.RemoteObject.prototype
 }