Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(716)

Issue 200423008: DevTools: Extend Runtime.CallArgument to pass numbers that can not be JSON-stringified. (Closed)

Created:
6 years, 9 months ago by aandrey
Modified:
6 years, 9 months ago
Reviewers:
pfeldman
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, alph+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, aandrey+blink_chromium.org
Visibility:
Public.

Description

DevTools: Extend Runtime.CallArgument to pass numbers that can not be JSON-stringified. These numbers are: NaN, Infinity, -Infinity, -0. R=pfeldman TEST=various existing tests Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=169376

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -27 lines) Patch
M Source/core/inspector/InjectedScriptSource.js View 1 2 chunks +16 lines, -2 lines 0 comments Download
M Source/devtools/front_end/RemoteObject.js View 4 chunks +17 lines, -22 lines 0 comments Download
M Source/devtools/protocol.json View 1 2 chunks +4 lines, -3 lines 0 comments Download

Messages

Total messages: 13 (0 generated)
aandrey
6 years, 9 months ago (2014-03-17 16:47:24 UTC) #1
pfeldman
lgtm
6 years, 9 months ago (2014-03-17 17:01:46 UTC) #2
aandrey
The CQ bit was checked by aandrey@chromium.org
6 years, 9 months ago (2014-03-17 17:05:18 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/aandrey@chromium.org/200423008/20001
6 years, 9 months ago (2014-03-17 17:05:40 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-17 17:08:23 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on win_blink_rel
6 years, 9 months ago (2014-03-17 17:08:24 UTC) #6
aandrey
The CQ bit was checked by aandrey@chromium.org
6 years, 9 months ago (2014-03-17 17:11:11 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/aandrey@chromium.org/200423008/40001
6 years, 9 months ago (2014-03-17 17:11:20 UTC) #8
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-17 17:25:30 UTC) #9
commit-bot: I haz the power
Commit queue rejected this change because the description was changed between the time the change ...
6 years, 9 months ago (2014-03-17 17:25:30 UTC) #10
aandrey
The CQ bit was checked by aandrey@chromium.org
6 years, 9 months ago (2014-03-17 18:08:53 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/aandrey@chromium.org/200423008/40001
6 years, 9 months ago (2014-03-17 18:08:58 UTC) #12
commit-bot: I haz the power
6 years, 9 months ago (2014-03-17 18:16:20 UTC) #13
Message was sent while issue was closed.
Change committed as 169376

Powered by Google App Engine
This is Rietveld 408576698