xfa/fwl/lightwidget/cfwl_widget.cpp - Issue 2004213002: Remove IWFL_WidgetMgr in favor of CFWL_WidgetMgr

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: xfa/fwl/lightwidget/cfwl_widget.cpp

Issue 2004213002: Remove IWFL_WidgetMgr in favor of CFWL_WidgetMgr (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: xfa/fwl/lightwidget/cfwl_widget.cpp

diff --git a/xfa/fwl/lightwidget/cfwl_widget.cpp b/xfa/fwl/lightwidget/cfwl_widget.cpp

index 8d3237605f858276446f488bde3ccb0a66c42261..88a2bf00cc00b210343e862f993ef9aa257cdbac 100644

--- a/xfa/fwl/lightwidget/cfwl_widget.cpp

+++ b/xfa/fwl/lightwidget/cfwl_widget.cpp

@@ -217,7 +217,7 @@ IFWL_WidgetDelegate* CFWL_Widget::SetDelegate(IFWL_WidgetDelegate* pDelegate) {

CFWL_Widget::CFWL_Widget()

: m_pIface(nullptr), m_pDelegate(nullptr), m_pProperties(nullptr) {

m_pProperties = new CFWL_WidgetProperties;

- m_pWidgetMgr = static_cast<CFWL_WidgetMgr*>(FWL_GetWidgetMgr());

+ m_pWidgetMgr = static_cast<CFWL_WidgetMgr*>(IFWL_WidgetMgr::GetInstance());

Lei Zhang 2016/05/23 21:57:20 Do we want to get rid of IFWL_WidgetMgr altogether

Tom Sepez 2016/05/23 22:02:54 Yes, I think so.

ASSERT(m_pWidgetMgr);

}

« no previous file with comments | « xfa/fwl/core/ifwl_widgetmgr.h ('k') | xfa/fwl/theme/cfwl_widgettp.cpp » ('j') | no next file with comments »