Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Issue 2004203003: fix rotated and alpha bitmaps (Closed)

Created:
4 years, 7 months ago by caryclark
Modified:
4 years, 6 months ago
Reviewers:
dsinclair, reed1
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

fix rotated and alpha bitmaps Match the matrix supplied by PDFium to the one expected by Skia to draw bitmaps. Set up the color if the bitmap is an image mask. Additional work required to figure out when bitmap filtering should be applied. R=reed@google.com,dsinclair@chromium.org BUG= Committed: https://pdfium.googlesource.com/pdfium/+/d6faaaab0749d80b78bc9bb6ef5126c81dc3ffa2

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -20 lines) Patch
M core/fxge/skia/fx_skia_device.cpp View 4 chunks +15 lines, -20 lines 2 comments Download

Messages

Total messages: 6 (2 generated)
dsinclair
lgtm https://codereview.chromium.org/2004203003/diff/1/core/fxge/skia/fx_skia_device.cpp File core/fxge/skia/fx_skia_device.cpp (right): https://codereview.chromium.org/2004203003/diff/1/core/fxge/skia/fx_skia_device.cpp#newcode1073 core/fxge/skia/fx_skia_device.cpp:1073: // paint.setFilterQuality(kHigh_SkFilterQuality); Remove if not needed.
4 years, 7 months ago (2016-05-25 00:40:18 UTC) #1
caryclark
https://codereview.chromium.org/2004203003/diff/1/core/fxge/skia/fx_skia_device.cpp File core/fxge/skia/fx_skia_device.cpp (right): https://codereview.chromium.org/2004203003/diff/1/core/fxge/skia/fx_skia_device.cpp#newcode1073 core/fxge/skia/fx_skia_device.cpp:1073: // paint.setFilterQuality(kHigh_SkFilterQuality); On 2016/05/25 00:40:18, dsinclair wrote: > Remove ...
4 years, 6 months ago (2016-05-25 13:17:20 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2004203003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2004203003/1
4 years, 6 months ago (2016-05-25 13:17:45 UTC) #4
commit-bot: I haz the power
4 years, 6 months ago (2016-05-25 13:27:49 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://pdfium.googlesource.com/pdfium/+/d6faaaab0749d80b78bc9bb6ef5126c81dc3...

Powered by Google App Engine
This is Rietveld 408576698