Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(443)

Issue 2004183002: Delete third_party/html_office. (Closed)

Created:
4 years, 7 months ago by dsansome
Modified:
4 years, 7 months ago
Reviewers:
agable
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Delete third_party/html_office. This is an old gitlink entry referring to a revision in another git repository, but it doesn't appear to be used, and causes git submodule to fail. $ git ls-files -s third_party/html_office 160000 1d04f3dfbd8bd604190dfb6f5a030d30233ba6ea 0 third_party/html_office (mode 160000 is a gitlink, see git-fast-import(1)) R=agable@chromium.org TBR=agable@chromium.org Committed: https://chromium.googlesource.com/chromium/src/+/ac0106a1dd9ea8c3c0b829985d257c4592872e06

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M build/whitespace_file.txt View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 7 (4 generated)
agable
lgtm
4 years, 7 months ago (2016-05-23 20:50:08 UTC) #2
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/ac0106a1dd9ea8c3c0b829985d257c4592872e06 Cr-Commit-Position: refs/heads/master@{#395409}
4 years, 7 months ago (2016-05-23 21:02:32 UTC) #5
agable
4 years, 7 months ago (2016-05-23 21:03:49 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
ac0106a1dd9ea8c3c0b829985d257c4592872e06 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698