Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(62)

Issue 2004173003: S390: [cleanup] Drop FLAG_eliminate_prototype_chain_checks (Closed)

Created:
4 years, 7 months ago by john.yan
Modified:
4 years, 7 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

S390: [cleanup] Drop FLAG_eliminate_prototype_chain_checks port eac1b38d9ae4091fb7feb6568a070273b9483237 Original Commit Message: This flag has been on by default for a while, along with FLAG_track_prototype_users which provides the prerequisite infrastructure. We are now sure that this is the direction we want to go in, so in order to simplify the code, this CL drops the respective flag-off code paths. R=jkummerow@chromium.org, joransiu@ca.ibm.com, michael_dawson@ca.ibm.com, mbrandy@us.ibm.com BUG= Committed: https://crrev.com/0223cbd63d4dd5f4bb551f86d2d85e2ed551e550 Cr-Commit-Position: refs/heads/master@{#36491}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -55 lines) Patch
M src/ic/s390/handler-compiler-s390.cc View 4 chunks +24 lines, -55 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
john.yan
PTAL
4 years, 7 months ago (2016-05-24 14:22:52 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2004173003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2004173003/1
4 years, 7 months ago (2016-05-24 18:34:56 UTC) #3
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 7 months ago (2016-05-24 18:58:09 UTC) #5
JoranSiu
On 2016/05/24 18:58:09, commit-bot: I haz the power wrote: > Dry run: This issue passed ...
4 years, 7 months ago (2016-05-24 20:06:58 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2004173003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2004173003/1
4 years, 7 months ago (2016-05-24 20:10:57 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-24 20:13:02 UTC) #9
commit-bot: I haz the power
4 years, 7 months ago (2016-05-24 20:14:27 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0223cbd63d4dd5f4bb551f86d2d85e2ed551e550
Cr-Commit-Position: refs/heads/master@{#36491}

Powered by Google App Engine
This is Rietveld 408576698