Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(493)

Issue 2004143002: Retry of 2b0e51237fa07b4fb9f6c20edcefce094f6cf5f5 (Closed)

Created:
4 years, 7 months ago by Evan Stade
Modified:
4 years, 7 months ago
Reviewers:
Lei Zhang, blundell, sky, scottmg
CC:
chromium-reviews, extensions-reviews_chromium.org, grt+watch_chromium.org, oshima+watch_chromium.org, wfh+watch_chromium.org, chromium-apps-reviews_chromium.org, Michael Moss
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Retry of 2b0e51237fa07b4fb9f6c20edcefce094f6cf5f5 Remove enable_topchrome_md build flag Actually use of MD is still controlled by a runtime flag. Also get rid of Material Design resource build step (on !osx). These drop-in png replacements are no longer used (they've all been converted to vectorized images). BUG=613980 TBR=sky@chromium.org,scottmg@chromium.org,blundell@chromium.org Committed: https://crrev.com/476ef356a5b0d6fb075844a4099d1f38c811301f Cr-Commit-Position: refs/heads/master@{#395392}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -153 lines) Patch
M build/common.gypi View 7 chunks +0 lines, -18 lines 0 comments Download
M build/config/BUILD.gn View 1 chunk +0 lines, -3 lines 0 comments Download
M build/config/ui.gni View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/BUILD.gn View 4 chunks +5 lines, -4 lines 0 comments Download
M chrome/app/theme/BUILD.gn View 2 chunks +7 lines, -2 lines 0 comments Download
M chrome/app/theme/theme_resources.grd View 3 chunks +11 lines, -11 lines 0 comments Download
M chrome/browser_tests.isolate View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/chrome_dll_bundle.gypi View 2 chunks +1 line, -9 lines 0 comments Download
M chrome/chrome_repack_chrome_material_100_percent.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/chrome_repack_chrome_material_200_percent.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/chrome_resources.gyp View 3 chunks +10 lines, -26 lines 0 comments Download
M chrome/installer/linux/common/installer.include View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/installer/mini_installer/chrome.release View 2 chunks +0 lines, -2 lines 0 comments Download
M chrome/interactive_ui_tests.isolate View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/test/BUILD.gn View 5 chunks +7 lines, -11 lines 0 comments Download
M chrome/tools/build/chromeos/FILES.cfg View 1 chunk +0 lines, -8 lines 0 comments Download
M chrome/tools/build/linux/FILES.cfg View 1 chunk +0 lines, -8 lines 0 comments Download
M chrome/tools/build/win/FILES.cfg View 1 chunk +0 lines, -9 lines 0 comments Download
M components/resources/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
M components/resources/components_scaled_resources.grd View 1 chunk +0 lines, -2 lines 0 comments Download
D components/resources/material_100_percent/omnibox/controlled_setting_mandatory.png View Binary file 0 comments Download
D components/resources/material_100_percent/omnibox/location_bar_http.png View Binary file 0 comments Download
D components/resources/material_100_percent/omnibox/omnibox_extension_app.png View Binary file 0 comments Download
D components/resources/material_100_percent/omnibox/omnibox_http.png View Binary file 0 comments Download
D components/resources/material_100_percent/omnibox/omnibox_search.png View Binary file 0 comments Download
D components/resources/material_200_percent/omnibox/controlled_setting_mandatory.png View Binary file 0 comments Download
D components/resources/material_200_percent/omnibox/location_bar_http.png View Binary file 0 comments Download
D components/resources/material_200_percent/omnibox/omnibox_extension_app.png View Binary file 0 comments Download
D components/resources/material_200_percent/omnibox/omnibox_http.png View Binary file 0 comments Download
D components/resources/material_200_percent/omnibox/omnibox_search.png View Binary file 0 comments Download
M tools/grit/grit_rule.gni View 1 chunk +0 lines, -6 lines 0 comments Download
M ui/base/material_design/material_design_controller.cc View 2 chunks +0 lines, -4 lines 0 comments Download
M ui/base/material_design/material_design_controller_unittest.cc View 3 chunks +0 lines, -16 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
Evan Stade
thestig, please review chrome/test/BUILD.gn (which contains all the differences from the previous patch to this ...
4 years, 7 months ago (2016-05-23 18:18:30 UTC) #2
Lei Zhang
lgtm
4 years, 7 months ago (2016-05-23 18:22:23 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2004143002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2004143002/1
4 years, 7 months ago (2016-05-23 18:36:28 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-23 19:54:06 UTC) #8
commit-bot: I haz the power
4 years, 7 months ago (2016-05-23 19:56:10 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/476ef356a5b0d6fb075844a4099d1f38c811301f
Cr-Commit-Position: refs/heads/master@{#395392}

Powered by Google App Engine
This is Rietveld 408576698