Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Issue 2004133002: [Media Router WebUI] Disable search by default. (Closed)

Created:
4 years, 7 months ago by btolsch
Modified:
4 years, 7 months ago
Reviewers:
apacible, amp
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2743
Target Ref:
refs/pending/branch-heads/2743
Project:
chromium
Visibility:
Public.

Description

[Media Router WebUI] Disable search by default. This change disables the search feature by default, only enabling it for exceptionally long sink lists and when pseudo sinks are available. Whether search is enabled is determined when the list of available sinks is updated. Once it has been enabled, it will not be disabled for the rest of the life of the dialog. R=amp@chromium.org, apacible@chromium.org BUG=612969 NOTRY=true NOPRESUBMIT=true Review-Url: https://codereview.chromium.org/1993003002 Cr-Commit-Position: refs/heads/master@{#395128} (cherry picked from commit 4d46c6973164274ba1e67242eae30bbc9050fce0)

Patch Set 1 #

Messages

Total messages: 12 (5 generated)
btolsch
Merging this back to M52, no conflicts. PTAL, thanks!
4 years, 7 months ago (2016-05-23 17:50:22 UTC) #1
apacible
rs lgtm
4 years, 7 months ago (2016-05-23 17:53:47 UTC) #2
amp
lgtm
4 years, 7 months ago (2016-05-23 19:59:47 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2004133002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2004133002/1
4 years, 7 months ago (2016-05-23 20:22:44 UTC) #5
commit-bot: I haz the power
CLs for remote refs other than refs/pending/heads/master must contain NOTRY=true and NOPRESUBMIT=true in order for ...
4 years, 7 months ago (2016-05-23 20:22:47 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2004133002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2004133002/1
4 years, 7 months ago (2016-05-23 20:30:38 UTC) #10
commit-bot: I haz the power
4 years, 7 months ago (2016-05-23 20:33:15 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1)

Powered by Google App Engine
This is Rietveld 408576698