Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Issue 2004113002: Update image testing to version 6 (Closed)

Created:
4 years, 7 months ago by msarett
Modified:
4 years, 7 months ago
Reviewers:
scroggo, borenet
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Update image testing to version 6 This replaces the old HTC.dng test image (~40 MB) with a much smaller HTC.dng (~125 kb). This should limit OOM errors on our bots and improve the speed of the tests suite. BUG=skia:5283 BUG=skia:5307 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2004113002 Committed: https://skia.googlesource.com/skia/+/3d7356a833ec30b33944b52dcd429f7b641d9559

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M SK_IMAGE_VERSION View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (4 generated)
msarett
4 years, 7 months ago (2016-05-23 16:54:32 UTC) #3
borenet
Is it just the one changed image? Please remove HTC.dng from the blacklist in tools/dm_flags.py.
4 years, 7 months ago (2016-05-23 16:55:57 UTC) #4
scroggo
LGTM, thanks!
4 years, 7 months ago (2016-05-23 16:56:00 UTC) #5
scroggo
On 2016/05/23 16:55:57, borenet wrote: > Is it just the one changed image? Please remove ...
4 years, 7 months ago (2016-05-23 16:59:10 UTC) #6
borenet
On 2016/05/23 16:59:10, scroggo wrote: > On 2016/05/23 16:55:57, borenet wrote: > > Is it ...
4 years, 7 months ago (2016-05-23 16:59:42 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2004113002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2004113002/1
4 years, 7 months ago (2016-05-23 17:00:55 UTC) #9
commit-bot: I haz the power
4 years, 7 months ago (2016-05-23 17:19:29 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/3d7356a833ec30b33944b52dcd429f7b641d9559

Powered by Google App Engine
This is Rietveld 408576698