Issue 20041: Make possible using pointer as a hash_table key when compiling using GCC.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 20041: Make possible using pointer as a hash_table key when compiling using GCC. (Closed)

Created:
11 years, 10 months ago by Paweł Hajdan Jr.

Modified:
9 years, 7 months ago

Reviewers:
pink (ping after 24hrs), Avi (use Gerrit)

CC:
chromium-reviews_googlegroups.com

Visibility:
Public.

Description

Make possible using pointer as a hash_table key when compiling using GCC.

Patch Set 1 #

Created: 11 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+16 lines, -2 lines)			Patch
	M	base/hash_tables.h	View		2 chunks	+16 lines, -2 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Paweł Hajdan Jr.

Assigning you as a reviewer because you did similar things earlier. This is needed for ...

11 years, 10 months ago (2009-02-04 17:02:41 UTC) #1

pink (ping after 24hrs)

LGTM. Can you also remove the hash I added to profile.h if this generic one ...

11 years, 10 months ago (2009-02-04 17:04:53 UTC) #2

Avi (use Gerrit)

Wait... If I'm reading this right, this means that we're just using an identity hash ...

11 years, 10 months ago (2009-02-04 17:06:46 UTC) #3

pink (ping after 24hrs)

Good point, Avi, though it seems like that's probably exactly what windows has to be ...

11 years, 10 months ago (2009-02-04 17:08:58 UTC) #4

Avi (use Gerrit)

11 years, 10 months ago (2009-02-04 17:18:00 UTC) #5

On 2009/02/04 17:08:58, pink wrote:
> I'm ok with being specific at the class-level. It seems we don't have to do it
> often.

My question is really: what's right for most of the classes? If identity is
right for most classes, then this might be the right thing to do. I just don't
know. Who out there could give a good answer?

Expand Messages | Collapse Messages