Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Issue 2004073002: SkTypes: use constexpr when appropriate (Closed)

Created:
4 years, 7 months ago by hal.canary
Modified:
4 years, 7 months ago
Reviewers:
bungeman-skia, reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 : 2016-05-23 (Monday) 11:27:21 EDT #

Patch Set 2 : 2016-05-23 (Monday) 11:56:10 EDT #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -4 lines) Patch
M include/core/SkTypes.h View 3 chunks +4 lines, -4 lines 0 comments Download
M tests/CPlusPlusEleven.cpp View 1 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 20 (10 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2004073002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2004073002/1
4 years, 7 months ago (2016-05-23 15:26:04 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2004073002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2004073002/20001
4 years, 7 months ago (2016-05-23 15:27:44 UTC) #7
hal.canary
PTAL
4 years, 7 months ago (2016-05-23 15:28:26 UTC) #9
bungeman-skia
lgtm
4 years, 7 months ago (2016-05-23 15:33:34 UTC) #10
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 7 months ago (2016-05-23 15:41:39 UTC) #12
reed1
lgtm
4 years, 7 months ago (2016-05-23 15:44:13 UTC) #13
reed1
Perhaps a unittest that ensures we don't break/remove this in the future.
4 years, 7 months ago (2016-05-23 15:45:29 UTC) #14
hal.canary
On 2016/05/23 15:45:29, reed1 wrote: > Perhaps a unittest that ensures we don't break/remove this ...
4 years, 7 months ago (2016-05-23 15:57:19 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2004073002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2004073002/40001
4 years, 7 months ago (2016-05-23 15:57:38 UTC) #18
commit-bot: I haz the power
4 years, 7 months ago (2016-05-23 16:12:02 UTC) #20
Message was sent while issue was closed.
Committed patchset #2 (id:40001) as
https://skia.googlesource.com/skia/+/a0af771612db5ae36b74f1f536bfb335ecd0ec99

Powered by Google App Engine
This is Rietveld 408576698