Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2004063003:
[build] Enable -Wlong-long compiler warning. (Closed)
|
Created:
4 years, 7 months ago by Michael Achenbach Modified:
4 years, 7 months ago CC:
v8-reviews_googlegroups.com, Michael Achenbach Base URL:
https://chromium.googlesource.com/v8/v8.git@master Target Ref:
refs/pending/heads/master Project:
v8 Visibility:
Public. |
Description[build] Enable -Wlong-long compiler warning.
BUG=chromium:474921
Committed: https://crrev.com/daae44f69bae36c28c29110f8bfda10978ec329c
Cr-Commit-Position: refs/heads/master@{#36471}
Patch Set 1 #
Messages
Total messages: 16 (8 generated)
Description was changed from ========== [build] Enable a compiler warning. BUG= ========== to ========== [build] Enable a compiler warning. BUG=chromium:474921 ==========
The CQ bit was checked by machenbach@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2004063003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2004063003/1
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
machenbach@chromium.org changed reviewers: + jkummerow@chromium.org, vogelheim@chromium.org
PTAL. Speculatively removing this.
lgtm nitpick: Please put the warning into the CL title/description. E.g., Enable compiler warning -Wlong-long. (People frequently scan commit logs, which is why I'll probably keep insisting that some base-level of information is present in them.)
Description was changed from ========== [build] Enable a compiler warning. BUG=chromium:474921 ========== to ========== [build] Enable -Wlong-long compiler warning. BUG=chromium:474921 ==========
Done
The CQ bit was checked by machenbach@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2004063003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2004063003/1
Message was sent while issue was closed.
Description was changed from ========== [build] Enable -Wlong-long compiler warning. BUG=chromium:474921 ========== to ========== [build] Enable -Wlong-long compiler warning. BUG=chromium:474921 ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== [build] Enable -Wlong-long compiler warning. BUG=chromium:474921 ========== to ========== [build] Enable -Wlong-long compiler warning. BUG=chromium:474921 Committed: https://crrev.com/daae44f69bae36c28c29110f8bfda10978ec329c Cr-Commit-Position: refs/heads/master@{#36471} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/daae44f69bae36c28c29110f8bfda10978ec329c Cr-Commit-Position: refs/heads/master@{#36471} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
