Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3741)

Unified Diff: chrome/browser/ui/browser_dialogs.h

Issue 2004043003: Expose the MacViewsWebUIDialogs feature flag to chrome://flags (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@20160520-Enums-MakeThemInt-HeaderChanges-ROLLUP
Patch Set: remove unused #includes Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/about_flags.cc ('k') | chrome/browser/ui/browser_dialogs_mac.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/browser_dialogs.h
diff --git a/chrome/browser/ui/browser_dialogs.h b/chrome/browser/ui/browser_dialogs.h
index 968999d49c37cb66c99b0db8e0e246661ba6e8d3..864cfdae54237773473539cb9abaa8a8708a1a9c 100644
--- a/chrome/browser/ui/browser_dialogs.h
+++ b/chrome/browser/ui/browser_dialogs.h
@@ -18,6 +18,10 @@ class GURL;
class LoginHandler;
class Profile;
+namespace base {
+struct Feature;
+}
+
namespace bookmarks {
class BookmarkBubbleObserver;
}
@@ -48,6 +52,14 @@ class WebDialogDelegate;
namespace chrome {
+#if defined(OS_MACOSX)
+// Makes ToolkitViewsDialogsEnabled() available to chrome://flags.
+extern const base::Feature kMacViewsNativeDialogs;
+
+// Makes ToolkitViewsWebUIDialogsEnabled() available to chrome://flags.
+extern const base::Feature kMacViewsWebUIDialogs;
+#endif // OS_MACOSX
+
// Shows or hides the Task Manager. |browser| can be NULL when called from Ash.
// Returns a pointer to the underlying TableModel, which can be ignored, or used
// for testing.
@@ -85,12 +97,11 @@ content::ColorChooser* ShowColorChooser(content::WebContents* web_contents,
#if defined(OS_MACOSX)
// For Mac, returns true if Chrome should show an equivalent toolkit-views based
-// dialog using one of the functions below, rather than showing a Cocoa dialog.
+// dialog instead of a native-looking Cocoa dialog.
bool ToolkitViewsDialogsEnabled();
// For Mac, returns true if Chrome should show an equivalent toolkit-views based
-// dialog instead of a WebUI-styled Cocoa dialog. ToolkitViewsDialogsEnabled()
-// implies ToolkitViewsWebUIDialogsEnabled().
+// dialog instead of a WebUI-styled Cocoa dialog.
bool ToolkitViewsWebUIDialogsEnabled();
// Shows a Views website settings bubble at the given anchor point.
« no previous file with comments | « chrome/browser/about_flags.cc ('k') | chrome/browser/ui/browser_dialogs_mac.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698