Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(114)

Side by Side Diff: chrome/browser/ui/browser_dialogs_mac.cc

Issue 2004043003: Expose the MacViewsWebUIDialogs feature flag to chrome://flags (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@20160520-Enums-MakeThemInt-HeaderChanges-ROLLUP
Patch Set: no c/b/ui for android Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/browser_dialogs.h" 5 #include "chrome/browser/ui/browser_dialogs.h"
6 6
7 #include "base/command_line.h" 7 #include "base/command_line.h"
8 #include "base/feature_list.h" 8 #include "base/feature_list.h"
9 #include "chrome/common/chrome_switches.h" 9 #include "chrome/common/chrome_switches.h"
10 10
11 namespace chrome {
12
11 const base::Feature kMacViewsWebUIDialogs { 13 const base::Feature kMacViewsWebUIDialogs {
12 "MacViewsWebUIDialogs", base::FEATURE_DISABLED_BY_DEFAULT 14 "MacViewsWebUIDialogs", base::FEATURE_DISABLED_BY_DEFAULT
13 }; 15 };
14 16
15 namespace chrome {
16
17 bool ToolkitViewsDialogsEnabled() { 17 bool ToolkitViewsDialogsEnabled() {
18 return base::CommandLine::ForCurrentProcess()->HasSwitch( 18 return base::CommandLine::ForCurrentProcess()->HasSwitch(
msw 2016/05/24 17:01:29 optional nit: convert this to a feature for parity
tapted 2016/05/25 12:01:49 Done. I do like consistency :). But my conscience
19 switches::kEnableMacViewsDialogs); 19 switches::kEnableMacViewsDialogs);
20 } 20 }
21 21
22 bool ToolkitViewsWebUIDialogsEnabled() { 22 bool ToolkitViewsWebUIDialogsEnabled() {
23 return base::FeatureList::IsEnabled(kMacViewsWebUIDialogs); 23 return base::FeatureList::IsEnabled(kMacViewsWebUIDialogs);
24 } 24 }
25 25
26 } // namespace chrome 26 } // namespace chrome
OLDNEW
« chrome/app/generated_resources.grd ('K') | « chrome/browser/ui/browser_dialogs.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698