Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(156)

Unified Diff: chrome/browser/extensions/extension_sync_service.cc

Issue 2004043002: Supervised Users Initiated Installs v2 (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@kid_initiated_install
Patch Set: Style fix Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/extension_sync_service.cc
diff --git a/chrome/browser/extensions/extension_sync_service.cc b/chrome/browser/extensions/extension_sync_service.cc
index 86824c6673779da2f85b79f15c1ccf6b72c6b467..e7063a29c39edcdb5e6f078b58b227d8d63fb071 100644
--- a/chrome/browser/extensions/extension_sync_service.cc
+++ b/chrome/browser/extensions/extension_sync_service.cc
@@ -105,7 +105,7 @@ syncer::SyncDataList ToSyncerSyncDataList(
return result;
}
-static_assert(Extension::DISABLE_REASON_LAST == (1 << 15),
+static_assert(Extension::DISABLE_REASON_LAST == (1 << 16),
"Please consider whether your new disable reason should be"
" syncable, and if so update this bitmask accordingly!");
const int kKnownSyncableDisableReasons =
@@ -282,16 +282,17 @@ ExtensionSyncData ExtensionSyncService::CreateSyncData(
GetAllowedOnAllUrlsOptionalBoolean(id, profile_);
AppSorting* app_sorting = ExtensionSystem::Get(profile_)->app_sorting();
- ExtensionSyncData result = extension.is_app()
- ? ExtensionSyncData(
- extension, enabled, disable_reasons, incognito_enabled,
- remote_install, allowed_on_all_url,
- app_sorting->GetAppLaunchOrdinal(id),
- app_sorting->GetPageOrdinal(id),
- extensions::GetLaunchTypePrefValue(extension_prefs, id))
- : ExtensionSyncData(
- extension, enabled, disable_reasons, incognito_enabled,
- remote_install, allowed_on_all_url);
+ ExtensionSyncData result =
+ extension.is_app()
Marc Treib 2016/05/23 15:32:42 Also here: Please avoid unrelated formatting chang
mamir 2016/05/23 19:35:14 I got confused while moving between different bran
+ ? ExtensionSyncData(
+ extension, enabled, disable_reasons, incognito_enabled,
+ remote_install, allowed_on_all_url,
+ app_sorting->GetAppLaunchOrdinal(id),
+ app_sorting->GetPageOrdinal(id),
+ extensions::GetLaunchTypePrefValue(extension_prefs, id))
+ : ExtensionSyncData(extension, enabled, disable_reasons,
+ incognito_enabled, remote_install,
+ allowed_on_all_url);
// If there's a pending update, send the new version to sync instead of the
// installed one.

Powered by Google App Engine
This is Rietveld 408576698