Supervised Users Initiated Installs v2

chrome/browser/supervised_user/supervised_user_settings_service.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_SUPERVISED_USER_SUPERVISED_USER_SETTINGS_SERVICE_H_
 #define CHROME_BROWSER_SUPERVISED_USER_SUPERVISED_USER_SETTINGS_SERVICE_H_
 
 #include <memory>
 #include <string>
 #include <vector>
@@ skipping 94 matching lines @@
   static std::string MakeSplitSettingKey(const std::string& prefix,
                                          const std::string& key);
 
   // Uploads an item to the Sync server. Items are the same data structure as
   // supervised user settings (i.e. key-value pairs, as described at the top of
   // the file), but they are only uploaded (whereas supervised user settings are
   // only downloaded), and never passed to the preference system.
   // An example of an uploaded item is an access request to a blocked URL.
   void UploadItem(const std::string& key, std::unique_ptr<base::Value> value);
 
+  // Updates supervised user settings and uploads it to the Sync server if they

[Marc Treib, 2016/06/08 12:08:25]

grammar: singular please. Also the "if they..." part is inaccurate; this method
doesn't check anything of the sort.

[mamir, 2016/06/09 12:14:10]

Done.

+  // change locally.  An example is when an extension updates without permission
+  // increase, the approved version information should be updated accordingly.
+  void UpdateSetting(const std::string& key,
+                     std::unique_ptr<base::Value> value);
+
   // Sets the setting with the given |key| to a copy of the given |value|.
   void SetLocalSetting(const std::string& key,
                        std::unique_ptr<base::Value> value);
 
   // Public for testing.
   static syncer::SyncData CreateSyncDataForSetting(const std::string& name,
                                                    const base::Value& value);
 
   // KeyedService implementation:
   void Shutdown() override;
@@ skipping 27 matching lines @@
   base::DictionaryValue* GetDictionaryAndSplitKey(std::string* key) const;
 
   // Returns a dictionary with all supervised user settings if the service is
   // active, or NULL otherwise.
   std::unique_ptr<base::DictionaryValue> GetSettings();
 
   // Sends the settings to all subscribers. This method should be called by the
   // subclass whenever the settings change.
   void InformSubscribers();
 
+  void PushItemToSync(const std::string& key,
+                      std::unique_ptr<base::Value> value);
+
   // Used for persisting the settings. Unlike other PrefStores, this one is not
   // directly hooked up to the PrefService.
   scoped_refptr<PersistentPrefStore> store_;
 
   Profile* profile_;
 
   bool active_;
 
   bool initialization_failed_;
 
   // A set of local settings that are fixed and not configured remotely.
   std::unique_ptr<base::DictionaryValue> local_settings_;
 
   SettingsCallbackList callback_list_;
 
   std::unique_ptr<syncer::SyncChangeProcessor> sync_processor_;
   std::unique_ptr<syncer::SyncErrorFactory> error_handler_;
 
   DISALLOW_COPY_AND_ASSIGN(SupervisedUserSettingsService);
 };
 
 #endif  // CHROME_BROWSER_SUPERVISED_USER_SUPERVISED_USER_SETTINGS_SERVICE_H_