Supervised Users Initiated Installs v2

chrome/browser/supervised_user/supervised_user_settings_service.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/supervised_user/supervised_user_settings_service.h"
 
 #include <stddef.h>
 
 #include <utility>
 
@@ skipping 117 matching lines @@
 std::string SupervisedUserSettingsService::MakeSplitSettingKey(
     const std::string& prefix,
     const std::string& key) {
   return prefix + kSplitSettingKeySeparator + key;
 }
 
 void SupervisedUserSettingsService::UploadItem(
     const std::string& key,
     std::unique_ptr<base::Value> value) {
   DCHECK(!SettingShouldApplyToPrefs(key));
+  PushItemToSync(key, std::move(value));
+}
 
+void SupervisedUserSettingsService::UpdateSetting(
+    const std::string& key,
+    std::unique_ptr<base::Value> value) {
+  PushItemToSync(key, std::move(value));
+  InformSubscribers();
+}
+
+void SupervisedUserSettingsService::PushItemToSync(
+    const std::string& key,
+    std::unique_ptr<base::Value> value) {
   std::string key_suffix = key;
   base::DictionaryValue* dict = nullptr;
   if (sync_processor_) {
     content::RecordAction(UserMetricsAction("ManagedUsers_UploadItem_Syncing"));
     dict = GetDictionaryAndSplitKey(&key_suffix);
     DCHECK(GetQueuedItems()->empty());
     SyncChangeList change_list;
     SyncData data = CreateSyncDataForSetting(key, *value);
     SyncChange::SyncChangeType change_type =
         dict->HasKey(key_suffix) ? SyncChange::ACTION_UPDATE
                                  : SyncChange::ACTION_ADD;
     change_list.push_back(SyncChange(FROM_HERE, change_type, data));
     SyncError error =
         sync_processor_->ProcessSyncChanges(FROM_HERE, change_list);
     DCHECK(!error.IsSet()) << error.ToString();
   } else {
     // Queue the item up to be uploaded when we start syncing
     // (in MergeDataAndStartSyncing()).
     content::RecordAction(UserMetricsAction("ManagedUsers_UploadItem_Queued"));
     dict = GetQueuedItems();
   }
   dict->SetWithoutPathExpansion(key_suffix, value.release());

[Marc Treib, 2016/06/08 12:08:25]

Not your doing, but could you use std::move(value) instead of value.release()?
The raw-pointer version of SetWithoutPathExpansion is deprecated.

[mamir, 2016/06/09 14:04:39]

Done.

 }
 
 void SupervisedUserSettingsService::SetLocalSetting(
     const std::string& key,
     std::unique_ptr<base::Value> value) {
   if (value)
     local_settings_->SetWithoutPathExpansion(key, value.release());
   else
     local_settings_->RemoveWithoutPathExpansion(key, nullptr);
 
@@ skipping 303 matching lines @@
   return settings;
 }
 
 void SupervisedUserSettingsService::InformSubscribers() {
   if (!IsReady())
     return;
 
   std::unique_ptr<base::DictionaryValue> settings = GetSettings();
   callback_list_.Notify(settings.get());
 }