Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(205)

Issue 2004023002: Fix typo in svg/dynamic-updates/SVGFEBlendElement-dom-in2-attr.html (Closed)

Created:
4 years, 7 months ago by fs
Modified:
4 years, 7 months ago
Reviewers:
davve, Noel Gordon
CC:
blink-reviews, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix typo in svg/dynamic-updates/SVGFEBlendElement-dom-in2-attr.html This test is not intended to test error-handling, so add the missing '#'. https://bugs.webkit.org/show_bug.cgi?id=158017 BUG=614306 Committed: https://crrev.com/f2972d02c64eec347d83aadfb6e3a52f69c9723b Cr-Commit-Position: refs/heads/master@{#395597}

Patch Set 1 #

Patch Set 2 : Reference bug in TE #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M third_party/WebKit/LayoutTests/TestExpectations View 1 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/svg/dynamic-updates/script-tests/SVGFEBlendElement-dom-in2-attr.js View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 17 (7 generated)
fs
4 years, 7 months ago (2016-05-23 13:47:05 UTC) #2
Noel Gordon
LGTM - with nits. Mozilla and Safari both use this test and have the exact ...
4 years, 7 months ago (2016-05-23 22:43:11 UTC) #3
Noel Gordon
Also, all patches should come with a BUG. What BUG should we use here?
4 years, 7 months ago (2016-05-24 01:03:40 UTC) #4
fs
On 2016/05/23 at 22:43:11, noel wrote: > LGTM - with nits. > > Mozilla and ...
4 years, 7 months ago (2016-05-24 09:09:51 UTC) #5
fs
On 2016/05/24 at 01:03:40, noel wrote: > Also, all patches should come with a BUG. ...
4 years, 7 months ago (2016-05-24 09:11:08 UTC) #8
davve
lgtm
4 years, 7 months ago (2016-05-24 09:42:19 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2004023002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2004023002/20001
4 years, 7 months ago (2016-05-24 15:00:01 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 7 months ago (2016-05-24 15:03:48 UTC) #14
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/f2972d02c64eec347d83aadfb6e3a52f69c9723b Cr-Commit-Position: refs/heads/master@{#395597}
4 years, 7 months ago (2016-05-24 15:05:25 UTC) #16
Noel Gordon
4 years, 7 months ago (2016-05-24 21:18:28 UTC) #17
Message was sent while issue was closed.
On 2016/05/24 09:11:08, fs wrote:
> On 2016/05/24 at 01:03:40, noel wrote:
> > Also, all patches should come with a BUG.  What BUG should we use here?
> 
> I don't agree with that for trivial cases like this (and lots of CLs land
> without bug references), but I'll file a bug for this and reference it before
> landing.

It's trivial to file a bug, and it helps record the history of our project: the
code changes we made and why.  In this case, it much easier to refer to a chrome
bug in _other code bases_, and that helps folks over there in Mozilla and WebKit
understand and adopt the change if wanted (for compat).  Thank you for filing
the WebKit bug.

For the record, I tried the original test case (before you change) in Mozilla
and it did not draw the element with the "url(darkenFilter)".  Anyho ...

Powered by Google App Engine
This is Rietveld 408576698