Fix typo in svg/dynamic-updates/SVGFEBlendElement-dom-in2-attr.html

Fix typo in svg/dynamic-updates/SVGFEBlendElement-dom-in2-attr.html

This test is not intended to test error-handling, so add the missing '#'.

https://bugs.webkit.org/show_bug.cgi?id=158017

BUG=614306
Committed: https://crrev.com/f2972d02c64eec347d83aadfb6e3a52f69c9723b
Cr-Commit-Position: refs/heads/master@{#395597}

[fs, 2016-05-23 13:47:04]

fs@opera.com changed reviewers:
+ davve@opera.com

[Noel Gordon, 2016-05-23 22:43:11]

LGTM - with nits.

Mozilla and Safari both use this test and have the exact same typo.  Can you
file a bug in their bug bases please, and refer to them in this CL's change
description?

[Noel Gordon, 2016-05-24 01:03:40]

Also, all patches should come with a BUG.  What BUG should we use here?

[fs, 2016-05-24 09:09:51]

On 2016/05/23 at 22:43:11, noel wrote:
> LGTM - with nits.
> 
> Mozilla and Safari both use this test and have the exact same typo.  Can you
file a bug in their bug bases please, and refer to them in this CL's change
description?

I did not find this test in the mozilla repo, I filed
https://bugs.webkit.org/show_bug.cgi?id=158017 for WebKit.

[fs, 2016-05-24 09:10:01]

Description was changed from

==========
Fix typo in svg/dynamic-updates/SVGFEBlendElement-dom-in2-attr.html

This test is not intended to test error-handling, so add the missing '#'.
==========

to

==========
Fix typo in svg/dynamic-updates/SVGFEBlendElement-dom-in2-attr.html

This test is not intended to test error-handling, so add the missing '#'.

https://bugs.webkit.org/show_bug.cgi?id=158017
==========

[fs, 2016-05-24 09:10:01]

fs@opera.com changed reviewers:
+ noel@chromium.org

[fs, 2016-05-24 09:11:08]

On 2016/05/24 at 01:03:40, noel wrote:
> Also, all patches should come with a BUG.  What BUG should we use here?

I don't agree with that for trivial cases like this (and lots of CLs land
without bug references), but I'll file a bug for this and reference it before
landing.

[fs, 2016-05-24 09:13:46]

Description was changed from

==========
Fix typo in svg/dynamic-updates/SVGFEBlendElement-dom-in2-attr.html

This test is not intended to test error-handling, so add the missing '#'.

https://bugs.webkit.org/show_bug.cgi?id=158017
==========

to

==========
Fix typo in svg/dynamic-updates/SVGFEBlendElement-dom-in2-attr.html

This test is not intended to test error-handling, so add the missing '#'.

https://bugs.webkit.org/show_bug.cgi?id=158017

BUG=614306
==========

[davve, 2016-05-24 09:42:19]

lgtm

[fs, 2016-05-24 14:59:47]

The CQ bit was checked by fs@opera.com

[fs, 2016-05-24 14:59:48]

The patchset sent to the CQ was uploaded after l-g-t-m from davve@opera.com,
noel@chromium.org
Link to the patchset: https://codereview.chromium.org/2004023002/#ps20001
(title: "Reference bug in TE")

[commit-bot: I haz the power, 2016-05-24 15:00:01]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2004023002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2004023002/20001

[commit-bot: I haz the power, 2016-05-24 15:03:48]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-05-24 15:05:23]

Description was changed from

==========
Fix typo in svg/dynamic-updates/SVGFEBlendElement-dom-in2-attr.html

This test is not intended to test error-handling, so add the missing '#'.

https://bugs.webkit.org/show_bug.cgi?id=158017

BUG=614306
==========

to

==========
Fix typo in svg/dynamic-updates/SVGFEBlendElement-dom-in2-attr.html

This test is not intended to test error-handling, so add the missing '#'.

https://bugs.webkit.org/show_bug.cgi?id=158017

BUG=614306

Committed: https://crrev.com/f2972d02c64eec347d83aadfb6e3a52f69c9723b
Cr-Commit-Position: refs/heads/master@{#395597}
==========

[commit-bot: I haz the power, 2016-05-24 15:05:25]

Patchset 2 (id:??) landed as
https://crrev.com/f2972d02c64eec347d83aadfb6e3a52f69c9723b
Cr-Commit-Position: refs/heads/master@{#395597}

[Noel Gordon, 2016-05-24 21:18:28]

On 2016/05/24 09:11:08, fs wrote:
> On 2016/05/24 at 01:03:40, noel wrote:
> > Also, all patches should come with a BUG.  What BUG should we use here?
> 
> I don't agree with that for trivial cases like this (and lots of CLs land
> without bug references), but I'll file a bug for this and reference it before
> landing.

It's trivial to file a bug, and it helps record the history of our project: the
code changes we made and why.  In this case, it much easier to refer to a chrome
bug in _other code bases_, and that helps folks over there in Mozilla and WebKit
understand and adopt the change if wanted (for compat).  Thank you for filing
the WebKit bug.

For the record, I tried the original test case (before you change) in Mozilla
and it did not draw the element with the "url(darkenFilter)".  Anyho ...