Issue 20040004: Allow handle dereference for --print-code.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 20040004: Allow handle dereference for --print-code. (Closed)

Created:
7 years, 5 months ago by Yang

Modified:
7 years, 5 months ago

Reviewers:
Jakob Kummerow

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Allow handle dereference for --print-code. R=jkummerow@chromium.org BUG= Committed: https://code.google.com/p/v8/source/detail?r=15862

Patch Set 2 : #

Created: 7 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -0 lines)			Patch
	M	src/codegen.cc	View	1	1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Jakob Kummerow

LGTM https://codereview.chromium.org/20040004/diff/1/src/codegen.cc File src/codegen.cc (right): https://codereview.chromium.org/20040004/diff/1/src/codegen.cc#newcode127 src/codegen.cc:127: AllowDeferredHandleDereference allow_deference_for_print_code; Why not move this inside the ...

7 years, 5 months ago (2013-07-24 14:27:27 UTC) #2

Yang

Committed patchset #1 manually as r15862 (presubmit successful).

7 years, 5 months ago (2013-07-24 14:29:01 UTC) #3

Yang

7 years, 5 months ago (2013-07-24 14:29:45 UTC) #4

Message was sent while issue was closed.

On 2013/07/24 14:29:01, Yang wrote:
> Committed patchset #1 manually as r15862 (presubmit successful).

done.

Expand Messages | Collapse Messages

Issue 20040004: Allow handle dereference for --print-code. (Closed)

Description

Patch Set 1 #

Patch Set 2 : #

Messages