Reland: MediaCaptureFromElement: add support for audio captureStream().

Reland: MediaCaptureFromElement: add support for audio captureStream().

The original CL got reverted due to flaky failures in
LayoutTests on bots, due to independent (racy)
initialization of the WebAudioSourceProviderImpl
and HTMLAudioElementCapturerSource. This extra
patch decouples both by making TeeFilter
independently initializable.

Original description --------------------------------------------------

MediaCaptureFromElement: add support for audio captureStream().

This CL extends support for capturing the audio part of
a <video> or <audio> tags ( "capture" here means creating
a MediaStream out of the HTMLElement)

It introduces an HtmlAudioCapturerSource is-a AudioCapturerSource
wrapped into an ExternalMediaStreamAudioSource to produce data
towards the audio track.

HtmlAudioCapturerSource also plugs into the
WebMediaPlayer's WebAudioSourceProviderImpl to get
a copy of the audio being rendered.

Unit tests are added, and the existing LayouTests
revamped (and split into several files for clarity).

BUG=569976, 575492
TEST= run chromium with
 --enable-blink-features=MediaCaptureFromVideo
 against e.g.
https://rawgit.com/Miguelao/demos/master/videoelementcapture.html
---------------------------------------------------------------------

TBR=haraken@chromium.org, avi@chromium.org, esprehn@chromium.org, miu@chromium.org
(reviewers whose reviewed code hasn't changed from the original
https://codereview.chromium.org/1599533003/)

Committed: https://crrev.com/6d69edab7acf4582c14ba7799dfda168395f26a2
Cr-Commit-Position: refs/heads/master@{#396200}

[mcasas, 2016-05-23 16:25:32]

Description was changed from

==========
Reland: MediaCaptureFromElement: add support for audio captureStream().


Original description --------------------------------------------------

MediaCaptureFromElement: add support for audio captureStream().

This CL extends support for capturing the audio part of
a <video> or <audio> tags ( "capture" here means creating
a MediaStream out of the HTMLElement)

It introduces an HtmlAudioCapturerSource is-a AudioCapturerSource
wrapped into an ExternalMediaStreamAudioSource to produce data
towards the audio track.

HtmlAudioCapturerSource also plugs into the
WebMediaPlayer's WebAudioSourceProviderImpl to get
a copy of the audio being rendered.

Unit tests are added, and the existing LayouTests
revamped (and split into several files for clarity).

BUG=569976, 575492
TEST= run chromium with
 --enable-blink-features=MediaCaptureFromVideo
 against e.g.
https://rawgit.com/Miguelao/demos/master/videoelementcapture.html
==========

to

==========
Reland: MediaCaptureFromElement: add support for audio captureStream().

The original CL got reverted due to flaky failures in 
LayoutTests on bots, due to independent (racy) 
initialization of the WebAudioSourceProviderImpl
and HTMLAudioElementCapturerSource. This extra
patch decouples both by making TeeFilter 
independently initializable.

Original description --------------------------------------------------

MediaCaptureFromElement: add support for audio captureStream().

This CL extends support for capturing the audio part of
a <video> or <audio> tags ( "capture" here means creating
a MediaStream out of the HTMLElement)

It introduces an HtmlAudioCapturerSource is-a AudioCapturerSource
wrapped into an ExternalMediaStreamAudioSource to produce data
towards the audio track.

HtmlAudioCapturerSource also plugs into the
WebMediaPlayer's WebAudioSourceProviderImpl to get
a copy of the audio being rendered.

Unit tests are added, and the existing LayouTests
revamped (and split into several files for clarity).

BUG=569976, 575492
TEST= run chromium with
 --enable-blink-features=MediaCaptureFromVideo
 against e.g.
https://rawgit.com/Miguelao/demos/master/videoelementcapture.html
==========

[mcasas, 2016-05-23 16:58:22]

mcasas@chromium.org changed reviewers:
+ dalecurtis@chromium.org

[mcasas, 2016-05-23 16:58:22]

dalecurtis@ PTAL at PS2 changes

[DaleCurtis, 2016-05-23 18:37:18]

https://codereview.chromium.org/2003963003/diff/20001/media/blink/webaudiosou...
File media/blink/webaudiosourceprovider_impl.cc (right):

https://codereview.chromium.org/2003963003/diff/20001/media/blink/webaudiosou...
media/blink/webaudiosourceprovider_impl.cc:123: if
(tee_filter_->IsInitialized())  // ???
Remove ???

https://codereview.chromium.org/2003963003/diff/20001/media/blink/webaudiosou...
media/blink/webaudiosourceprovider_impl.cc:267: if (!renderer_)
This should be impossible, no?

https://codereview.chromium.org/2003963003/diff/20001/media/blink/webaudiosou...
media/blink/webaudiosourceprovider_impl.cc:285: if (renderer_)
Ditto.

[mcasas, 2016-05-23 19:00:13]

PTAL

https://codereview.chromium.org/2003963003/diff/20001/media/blink/webaudiosou...
File media/blink/webaudiosourceprovider_impl.cc (right):

https://codereview.chromium.org/2003963003/diff/20001/media/blink/webaudiosou...
media/blink/webaudiosourceprovider_impl.cc:123: if
(tee_filter_->IsInitialized())  // ???
On 2016/05/23 18:37:18, DaleCurtis wrote:
> Remove ???

Done.

https://codereview.chromium.org/2003963003/diff/20001/media/blink/webaudiosou...
media/blink/webaudiosourceprovider_impl.cc:267: if (!renderer_)
On 2016/05/23 18:37:18, DaleCurtis wrote:
> This should be impossible, no?

It could be possible if we get data before the
|renderer_| has been set, but seeing your reaction
I believe is is enforced in the class contract. 
Changed for a DCHECK.

https://codereview.chromium.org/2003963003/diff/20001/media/blink/webaudiosou...
media/blink/webaudiosourceprovider_impl.cc:285: if (renderer_)
On 2016/05/23 18:37:18, DaleCurtis wrote:
> Ditto.

Acknowledged.

[mcasas, 2016-05-24 20:22:51]

On 2016/05/23 19:00:13, mcasas wrote:
> PTAL
> 
>
https://codereview.chromium.org/2003963003/diff/20001/media/blink/webaudiosou...
> File media/blink/webaudiosourceprovider_impl.cc (right):
> 
>
https://codereview.chromium.org/2003963003/diff/20001/media/blink/webaudiosou...
> media/blink/webaudiosourceprovider_impl.cc:123: if
> (tee_filter_->IsInitialized())  // ???
> On 2016/05/23 18:37:18, DaleCurtis wrote:
> > Remove ???
> 
> Done.
> 
>
https://codereview.chromium.org/2003963003/diff/20001/media/blink/webaudiosou...
> media/blink/webaudiosourceprovider_impl.cc:267: if (!renderer_)
> On 2016/05/23 18:37:18, DaleCurtis wrote:
> > This should be impossible, no?
> 
> It could be possible if we get data before the
> |renderer_| has been set, but seeing your reaction
> I believe is is enforced in the class contract. 
> Changed for a DCHECK.
> 
>
https://codereview.chromium.org/2003963003/diff/20001/media/blink/webaudiosou...
> media/blink/webaudiosourceprovider_impl.cc:285: if (renderer_)
> On 2016/05/23 18:37:18, DaleCurtis wrote:
> > Ditto.
> 
> Acknowledged.

dalecurtis@ ping

[DaleCurtis, 2016-05-24 20:29:48]

lgtm

[mcasas, 2016-05-26 15:06:58]

Description was changed from

==========
Reland: MediaCaptureFromElement: add support for audio captureStream().

The original CL got reverted due to flaky failures in 
LayoutTests on bots, due to independent (racy) 
initialization of the WebAudioSourceProviderImpl
and HTMLAudioElementCapturerSource. This extra
patch decouples both by making TeeFilter 
independently initializable.

Original description --------------------------------------------------

MediaCaptureFromElement: add support for audio captureStream().

This CL extends support for capturing the audio part of
a <video> or <audio> tags ( "capture" here means creating
a MediaStream out of the HTMLElement)

It introduces an HtmlAudioCapturerSource is-a AudioCapturerSource
wrapped into an ExternalMediaStreamAudioSource to produce data
towards the audio track.

HtmlAudioCapturerSource also plugs into the
WebMediaPlayer's WebAudioSourceProviderImpl to get
a copy of the audio being rendered.

Unit tests are added, and the existing LayouTests
revamped (and split into several files for clarity).

BUG=569976, 575492
TEST= run chromium with
 --enable-blink-features=MediaCaptureFromVideo
 against e.g.
https://rawgit.com/Miguelao/demos/master/videoelementcapture.html
==========

to

==========
Reland: MediaCaptureFromElement: add support for audio captureStream().

The original CL got reverted due to flaky failures in 
LayoutTests on bots, due to independent (racy) 
initialization of the WebAudioSourceProviderImpl
and HTMLAudioElementCapturerSource. This extra
patch decouples both by making TeeFilter 
independently initializable.

https://codereview.chromium.org/1599533003/
Original description --------------------------------------------------

MediaCaptureFromElement: add support for audio captureStream().

This CL extends support for capturing the audio part of
a <video> or <audio> tags ( "capture" here means creating
a MediaStream out of the HTMLElement)

It introduces an HtmlAudioCapturerSource is-a AudioCapturerSource
wrapped into an ExternalMediaStreamAudioSource to produce data
towards the audio track.

HtmlAudioCapturerSource also plugs into the
WebMediaPlayer's WebAudioSourceProviderImpl to get
a copy of the audio being rendered.

Unit tests are added, and the existing LayouTests
revamped (and split into several files for clarity).

BUG=569976, 575492
TEST= run chromium with
 --enable-blink-features=MediaCaptureFromVideo
 against e.g.
https://rawgit.com/Miguelao/demos/master/videoelementcapture.html
==========

[mcasas, 2016-05-26 15:08:34]

Description was changed from

==========
Reland: MediaCaptureFromElement: add support for audio captureStream().

The original CL got reverted due to flaky failures in 
LayoutTests on bots, due to independent (racy) 
initialization of the WebAudioSourceProviderImpl
and HTMLAudioElementCapturerSource. This extra
patch decouples both by making TeeFilter 
independently initializable.

https://codereview.chromium.org/1599533003/
Original description --------------------------------------------------

MediaCaptureFromElement: add support for audio captureStream().

This CL extends support for capturing the audio part of
a <video> or <audio> tags ( "capture" here means creating
a MediaStream out of the HTMLElement)

It introduces an HtmlAudioCapturerSource is-a AudioCapturerSource
wrapped into an ExternalMediaStreamAudioSource to produce data
towards the audio track.

HtmlAudioCapturerSource also plugs into the
WebMediaPlayer's WebAudioSourceProviderImpl to get
a copy of the audio being rendered.

Unit tests are added, and the existing LayouTests
revamped (and split into several files for clarity).

BUG=569976, 575492
TEST= run chromium with
 --enable-blink-features=MediaCaptureFromVideo
 against e.g.
https://rawgit.com/Miguelao/demos/master/videoelementcapture.html
==========

to

==========
Reland: MediaCaptureFromElement: add support for audio captureStream().

The original CL got reverted due to flaky failures in 
LayoutTests on bots, due to independent (racy) 
initialization of the WebAudioSourceProviderImpl
and HTMLAudioElementCapturerSource. This extra
patch decouples both by making TeeFilter 
independently initializable.

Original description --------------------------------------------------

MediaCaptureFromElement: add support for audio captureStream().

This CL extends support for capturing the audio part of
a <video> or <audio> tags ( "capture" here means creating
a MediaStream out of the HTMLElement)

It introduces an HtmlAudioCapturerSource is-a AudioCapturerSource
wrapped into an ExternalMediaStreamAudioSource to produce data
towards the audio track.

HtmlAudioCapturerSource also plugs into the
WebMediaPlayer's WebAudioSourceProviderImpl to get
a copy of the audio being rendered.

Unit tests are added, and the existing LayouTests
revamped (and split into several files for clarity).

BUG=569976, 575492
TEST= run chromium with
 --enable-blink-features=MediaCaptureFromVideo
 against e.g.
https://rawgit.com/Miguelao/demos/master/videoelementcapture.html
---------------------------------------------------------------------

TBR=haraken@chromium.org, avi@chromium.org, esprehn@chromium.org,
miu@chromium.org
(reviewers whose reviewed code hasn't changed from the original
https://codereview.chromium.org/1599533003/)
==========

[mcasas, 2016-05-26 15:08:52]

The CQ bit was checked by mcasas@chromium.org

[commit-bot: I haz the power, 2016-05-26 15:09:10]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2003963003/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2003963003/40001

[commit-bot: I haz the power, 2016-05-26 16:52:01]

Description was changed from

==========
Reland: MediaCaptureFromElement: add support for audio captureStream().

The original CL got reverted due to flaky failures in 
LayoutTests on bots, due to independent (racy) 
initialization of the WebAudioSourceProviderImpl
and HTMLAudioElementCapturerSource. This extra
patch decouples both by making TeeFilter 
independently initializable.

Original description --------------------------------------------------

MediaCaptureFromElement: add support for audio captureStream().

This CL extends support for capturing the audio part of
a <video> or <audio> tags ( "capture" here means creating
a MediaStream out of the HTMLElement)

It introduces an HtmlAudioCapturerSource is-a AudioCapturerSource
wrapped into an ExternalMediaStreamAudioSource to produce data
towards the audio track.

HtmlAudioCapturerSource also plugs into the
WebMediaPlayer's WebAudioSourceProviderImpl to get
a copy of the audio being rendered.

Unit tests are added, and the existing LayouTests
revamped (and split into several files for clarity).

BUG=569976, 575492
TEST= run chromium with
 --enable-blink-features=MediaCaptureFromVideo
 against e.g.
https://rawgit.com/Miguelao/demos/master/videoelementcapture.html
---------------------------------------------------------------------

TBR=haraken@chromium.org, avi@chromium.org, esprehn@chromium.org,
miu@chromium.org
(reviewers whose reviewed code hasn't changed from the original
https://codereview.chromium.org/1599533003/)
==========

to

==========
Reland: MediaCaptureFromElement: add support for audio captureStream().

The original CL got reverted due to flaky failures in 
LayoutTests on bots, due to independent (racy) 
initialization of the WebAudioSourceProviderImpl
and HTMLAudioElementCapturerSource. This extra
patch decouples both by making TeeFilter 
independently initializable.

Original description --------------------------------------------------

MediaCaptureFromElement: add support for audio captureStream().

This CL extends support for capturing the audio part of
a <video> or <audio> tags ( "capture" here means creating
a MediaStream out of the HTMLElement)

It introduces an HtmlAudioCapturerSource is-a AudioCapturerSource
wrapped into an ExternalMediaStreamAudioSource to produce data
towards the audio track.

HtmlAudioCapturerSource also plugs into the
WebMediaPlayer's WebAudioSourceProviderImpl to get
a copy of the audio being rendered.

Unit tests are added, and the existing LayouTests
revamped (and split into several files for clarity).

BUG=569976, 575492
TEST= run chromium with
 --enable-blink-features=MediaCaptureFromVideo
 against e.g.
https://rawgit.com/Miguelao/demos/master/videoelementcapture.html
---------------------------------------------------------------------

TBR=haraken@chromium.org, avi@chromium.org, esprehn@chromium.org,
miu@chromium.org
(reviewers whose reviewed code hasn't changed from the original
https://codereview.chromium.org/1599533003/)
==========

[commit-bot: I haz the power, 2016-05-26 16:52:02]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-05-26 16:53:06]

Description was changed from

==========
Reland: MediaCaptureFromElement: add support for audio captureStream().

The original CL got reverted due to flaky failures in 
LayoutTests on bots, due to independent (racy) 
initialization of the WebAudioSourceProviderImpl
and HTMLAudioElementCapturerSource. This extra
patch decouples both by making TeeFilter 
independently initializable.

Original description --------------------------------------------------

MediaCaptureFromElement: add support for audio captureStream().

This CL extends support for capturing the audio part of
a <video> or <audio> tags ( "capture" here means creating
a MediaStream out of the HTMLElement)

It introduces an HtmlAudioCapturerSource is-a AudioCapturerSource
wrapped into an ExternalMediaStreamAudioSource to produce data
towards the audio track.

HtmlAudioCapturerSource also plugs into the
WebMediaPlayer's WebAudioSourceProviderImpl to get
a copy of the audio being rendered.

Unit tests are added, and the existing LayouTests
revamped (and split into several files for clarity).

BUG=569976, 575492
TEST= run chromium with
 --enable-blink-features=MediaCaptureFromVideo
 against e.g.
https://rawgit.com/Miguelao/demos/master/videoelementcapture.html
---------------------------------------------------------------------

TBR=haraken@chromium.org, avi@chromium.org, esprehn@chromium.org,
miu@chromium.org
(reviewers whose reviewed code hasn't changed from the original
https://codereview.chromium.org/1599533003/)
==========

to

==========
Reland: MediaCaptureFromElement: add support for audio captureStream().

The original CL got reverted due to flaky failures in
LayoutTests on bots, due to independent (racy)
initialization of the WebAudioSourceProviderImpl
and HTMLAudioElementCapturerSource. This extra
patch decouples both by making TeeFilter
independently initializable.

Original description --------------------------------------------------

MediaCaptureFromElement: add support for audio captureStream().

This CL extends support for capturing the audio part of
a <video> or <audio> tags ( "capture" here means creating
a MediaStream out of the HTMLElement)

It introduces an HtmlAudioCapturerSource is-a AudioCapturerSource
wrapped into an ExternalMediaStreamAudioSource to produce data
towards the audio track.

HtmlAudioCapturerSource also plugs into the
WebMediaPlayer's WebAudioSourceProviderImpl to get
a copy of the audio being rendered.

Unit tests are added, and the existing LayouTests
revamped (and split into several files for clarity).

BUG=569976, 575492
TEST= run chromium with
 --enable-blink-features=MediaCaptureFromVideo
 against e.g.
https://rawgit.com/Miguelao/demos/master/videoelementcapture.html
---------------------------------------------------------------------

TBR=haraken@chromium.org, avi@chromium.org, esprehn@chromium.org,
miu@chromium.org
(reviewers whose reviewed code hasn't changed from the original
https://codereview.chromium.org/1599533003/)

Committed: https://crrev.com/6d69edab7acf4582c14ba7799dfda168395f26a2
Cr-Commit-Position: refs/heads/master@{#396200}
==========

[commit-bot: I haz the power, 2016-05-26 16:53:07]

Patchset 3 (id:??) landed as
https://crrev.com/6d69edab7acf4582c14ba7799dfda168395f26a2
Cr-Commit-Position: refs/heads/master@{#396200}

[stgao, 2016-05-26 18:52:03]

stgao@chromium.org changed reviewers:
+ stgao@chromium.org

[stgao, 2016-05-26 18:52:03]

It seems this CL is causing crash on
https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Win10/builds/1...

Regressions: Unexpected crashes (2)
  fast/mediacapturefromelement/HTMLMediaElementCapture-capture.html [ Crash ]
  fast/mediacapturefromelement/HTMLMediaElementCapture-creation.html [ Crash ]

[mcasas, 2016-05-26 19:10:45]

A revert of this CL (patchset #3 id:40001) has been created in
https://codereview.chromium.org/2014963002/ by mcasas@chromium.org.

The reason for reverting is:
https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Win10/builds/1...

crashed test.

(I wonder why that wasn't hit by CQ?).