Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(834)

Issue 2003963002: Apply scoped_ptr -> std::unique_ptr conversion to comment (Closed)

Created:
4 years, 7 months ago by davve
Modified:
4 years, 7 months ago
Reviewers:
Avi (use Gerrit)
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, creis+watch_chromium.org, nasko+codewatch_chromium.org, jam, darin-cc_chromium.org, mkwst+moarreviews-renderer_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Apply scoped_ptr -> std::unique_ptr conversion to comment date_time_picker_client_ is a std::unique_ptr now. R=avi NOTRY=true Committed: https://crrev.com/17e025e114817d40b737f08b1918b78281f534b5 Cr-Commit-Position: refs/heads/master@{#395331}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M content/renderer/render_view_impl.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
davve
My quickly tossed together scoped_ptr -> std::unique_ptr conversion scripts found this one when doing code ...
4 years, 7 months ago (2016-05-23 08:23:34 UTC) #1
Avi (use Gerrit)
lgtm Agreed.
4 years, 7 months ago (2016-05-23 15:27:06 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2003963002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2003963002/1
4 years, 7 months ago (2016-05-23 15:27:15 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-23 15:30:31 UTC) #5
commit-bot: I haz the power
4 years, 7 months ago (2016-05-23 15:32:23 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/17e025e114817d40b737f08b1918b78281f534b5
Cr-Commit-Position: refs/heads/master@{#395331}

Powered by Google App Engine
This is Rietveld 408576698