components/offline_pages/resources/offline_internals.css - Issue 2003883002: [Offline pages] Create offline internals page for Android

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: components/offline_pages/resources/offline_internals.css

Issue 2003883002: [Offline pages] Create offline internals page for Android (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« chrome/browser/ui/webui/offline_internals_ui.cc ('K') | « chrome/common/url_constants.cc ('k') | components/offline_pages/resources/offline_internals.html » ('j') | components/offline_pages/resources/offline_internals.js » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 /* Copyright (c) 2016 The Chromium Authors. All rights reserved.

	2 * Use of this source code is governed by a BSD-style license that can be

	3 * found in the LICENSE file.

	4 */

	5

	6 h1 {
	dewittj 2016/05/24 18:13:08 is this style copied from somewhere? I would pref is this style copied from somewhere? I would prefer if you use the suggestions in https://www.chromium.org/developers/updating-webui-for-material-design chili 2016/05/24 22:52:30 Polymer is just a way to more easily split html te Show quoted text On 2016/05/24 18:13:08, dewittj wrote: > is this style copied from somewhere? I would prefer if you use the suggestions > in https://www.chromium.org/developers/updating-webui-for-material-design Polymer is just a way to more easily split html templates into multiple smaller templates, and embed useful templating in the html. I spoke with dbeam@ (one of the owners of webui), who said that polymer in internal pages does not yet work with android (apparently adds a lot to the size). Since this will be primarily viewed on android, I will not be adding polymer. That said, this CSS doesn't really conform to material specs, but neither is there a 'default material css' provided. For a first pass, I think it's more important to have all the information in some readable format. I intend to do a CSS pass later for a purely visual touchup
	7 color: rgb(74, 142, 230);

	8 margin: 0;

	9 padding: 0;

	10 }

	11

	12 td {

	13 padding: 4px;

	14 }

	15

	16 tr:nth-child(odd) {

	17 background-color: azure;

	18 }

	19

	20 th {

	21 background-color: navy;

	22 color: white;

	23 font-weight: bold;

	24 }

	25

OLD	NEW