chrome/browser/ui/webui/offline_internals_ui.h - Issue 2003883002: [Offline pages] Create offline internals page for Android

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/ui/webui/offline_internals_ui.h

Issue 2003883002: [Offline pages] Create offline internals page for Android (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« chrome/browser/resources/offline_pages/offline_internals.js ('K') | « chrome/browser/ui/webui/chrome_web_ui_controller_factory.cc ('k') | chrome/browser/ui/webui/offline_internals_ui.cc » ('j') | chrome/browser/ui/webui/offline_internals_ui.cc » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 // Copyright 2016 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef CHROME_BROWSER_UI_WEBUI_OFFLINE_INTERNALS_UI_H_

	6 #define CHROME_BROWSER_UI_WEBUI_OFFLINE_INTERNALS_UI_H_

	7

	8 #include "base/macros.h"

	9 #include "content/public/browser/web_ui_controller.h"

	10

	11 // The WebUI for chrome://offline-internals
	Dan Beam 2016/05/26 00:54:39 nit: end with . nit: end with . chili 2016/05/27 01:37:00 Done. Show quoted text On 2016/05/26 00:54:39, Dan Beam wrote: > nit: end with . Done.
	12 class OfflineInternalsUI : public content::WebUIController {

	13 public:

	14 explicit OfflineInternalsUI(content::WebUI* web_ui);
	Dan Beam 2016/05/26 00:54:39 you should arguably forward-declare content::WebUI you should arguably forward-declare content::WebUI chili 2016/05/27 01:37:00 I don't know if that would help anything. I am al Show quoted text On 2016/05/26 00:54:39, Dan Beam wrote: > you should arguably forward-declare content::WebUI I don't know if that would help anything. I am already inheriting from content::WebUIController, so I need to have the #include anyway. WebUI is in the same .h file, so doesn't seem much of a difference?
	15 ~OfflineInternalsUI() override;

	16

	17 private:

	18 DISALLOW_COPY_AND_ASSIGN(OfflineInternalsUI);

	19 };

	20

	21 #endif // CHROME_BROWSER_UI_WEBUI_OFFLINE_INTERNALS_UI_H_

OLD	NEW