[Offline pages] Create offline internals page for Android

chrome/browser/ui/webui/offline_internals_ui.cc

+// Copyright 2016 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "chrome/browser/ui/webui/offline_internals_ui.h"
+
+#include "base/bind.h"
+#include "base/bind_helpers.h"

[Dan Beam, 2016/05/26 00:54:39]

doesn't look like you need bind_helpers.h

[chili, 2016/05/27 01:36:59]

Done.

+#include "base/macros.h"
+#include "base/memory/weak_ptr.h"
+#include "base/values.h"
+#include "chrome/browser/profiles/profile.h"
+#include "chrome/common/url_constants.h"
+#include "content/public/browser/web_ui.h"
+#include "content/public/browser/web_ui_controller.h"
+#include "content/public/browser/web_ui_data_source.h"
+#include "content/public/browser/web_ui_message_handler.h"
+#include "grit/browser_resources.h"
+
+namespace {
+
+// Class acting as a controller of the chrome://offline-internals WebUI.
+class OfflineInternalsUIMessageHandler : public content::WebUIMessageHandler {
+ public:
+  OfflineInternalsUIMessageHandler();

[Dan Beam, 2016/05/26 00:54:39]

if this class lives totally in the .cc, you can just inline all the method
bodies, i.e.

class OfflineInternalsUIMessageHandler : public content::WebUIMessageHandler {
 public:
  OfflineInternalsUIMessageHandler() : weak_ptr_factory_(this) {}
  ~OfflineInternalsUIMessageHandler() override {}

  void RegisterMessages() override {
    web_ui()->RegisterMessageCallback(...);
    ...
  }

[chili, 2016/05/27 01:36:59]

These methods are going to get more complicated when the data fetching stuff is
added in. The C++ dos and don'ts say that while there are weaker arguments
against inlining , the primary concern is readability.  I don't really see
readability being a big issue here, but I'll defer the answer to you

+  ~OfflineInternalsUIMessageHandler() override;
+
+  // WebUIMessageHandler implementation.
+  void RegisterMessages() override;
+
+ private:
+  // Deletes all the pages in the store.
+  void DeleteAllPages(const base::ListValue* args);
+
+  // Delete selected list of page ids from the store.
+  void DeleteSelectedPages(const base::ListValue* args);
+
+  // Load all information.
+  void GetOfflineInternalsInfo(const base::ListValue* args);
+
+  // Factory for creating references in callbacks.
+  base::WeakPtrFactory<OfflineInternalsUIMessageHandler> weak_ptr_factory_;
+
+  DISALLOW_COPY_AND_ASSIGN(OfflineInternalsUIMessageHandler);
+};
+
+OfflineInternalsUIMessageHandler::OfflineInternalsUIMessageHandler()
+    : weak_ptr_factory_(this) {}
+
+OfflineInternalsUIMessageHandler::~OfflineInternalsUIMessageHandler() {}
+
+void OfflineInternalsUIMessageHandler::DeleteAllPages(
+    const base::ListValue* args) {
+  web_ui()->CallJavascriptFunction("offlineInternals.pagesDeleted");
+}
+
+void OfflineInternalsUIMessageHandler::DeleteSelectedPages(
+    const base::ListValue* args) {
+  web_ui()->CallJavascriptFunction("offlineInternals.pagesDeleted");

[Dan Beam, 2016/05/26 00:54:39]

should this be different from DeleteSelectedPages?

[chili, 2016/05/27 01:36:59]

It will be in the next iteration, when I add the offline page model in.

+}
+
+void OfflineInternalsUIMessageHandler::GetOfflineInternalsInfo(
+    const base::ListValue* args) {
+  base::DictionaryValue results;
+  base::ListValue* pages = new base::ListValue();
+  base::ListValue* queueItems = new base::ListValue();

[Dan Beam, 2016/05/26 00:54:39]

maybe just inline these for now?  i.e.

results.Set("AllPages", new base::ListValue());
results.Set("Queue", new base::ListValue());

[chili, 2016/05/27 01:36:59]

Done.

+  results.Set("AllPages", pages);
+  results.Set("Queue", queueItems);
+
+  web_ui()->CallJavascriptFunction("offlineInternals.setOfflineInternalsInfo",
+                                   results);
+}
+
+void OfflineInternalsUIMessageHandler::RegisterMessages() {
+  web_ui()->RegisterMessageCallback(
+      "deleteAllPages",
+      base::Bind(&OfflineInternalsUIMessageHandler::DeleteAllPages,
+                 weak_ptr_factory_.GetWeakPtr()));
+  web_ui()->RegisterMessageCallback(
+      "deleteSelectPages",
+      base::Bind(&OfflineInternalsUIMessageHandler::DeleteSelectedPages,
+                 weak_ptr_factory_.GetWeakPtr()));
+  web_ui()->RegisterMessageCallback(
+      "getOfflineInternalsInfo",
+      base::Bind(&OfflineInternalsUIMessageHandler::GetOfflineInternalsInfo,
+                 weak_ptr_factory_.GetWeakPtr()));
+}
+
+}  // namespace
+
+OfflineInternalsUI::OfflineInternalsUI(content::WebUI* web_ui)
+    : content::WebUIController(web_ui) {
+  // chrome://offline-internals source.
+  content::WebUIDataSource* html_source =
+      content::WebUIDataSource::Create(chrome::kChromeUIOfflineInternalsHost);
+
+  // Required resources.
+  html_source->SetJsonPath("strings.js");
+  html_source->AddResourcePath("offline_internals.css",
+                               IDR_OFFLINE_INTERNALS_CSS);
+  html_source->AddResourcePath("offline_internals.js",
+                               IDR_OFFLINE_INTERNALS_JS);
+  html_source->SetDefaultResource(IDR_OFFLINE_INTERNALS_HTML);
+
+  content::WebUIDataSource::Add(Profile::FromWebUI(web_ui), html_source);
+
+  web_ui->AddMessageHandler(new OfflineInternalsUIMessageHandler());
+}
+
+OfflineInternalsUI::~OfflineInternalsUI() {}