Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1072)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2003873002: Fix infinite recursion in CPDF_DocPageData::GetColorSpace(). (Closed)

Created:
4 years, 7 months ago by Lei Zhang
Modified:
4 years, 7 months ago
Reviewers:
Tom Sepez
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium@master
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Fix infinite recursion in CPDF_DocPageData::GetColorSpace(). BUG=pdfium:497 Committed: https://pdfium.googlesource.com/pdfium/+/885bba0b002e2a70e7808e65a53d6f977ddccd95

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -7 lines) Patch
M core/fpdfapi/fpdf_page/fpdf_page_doc.cpp View 3 chunks +26 lines, -5 lines 0 comments Download
M core/fpdfapi/fpdf_page/pageint.h View 2 chunks +5 lines, -0 lines 0 comments Download
M core/fpdfapi/fpdf_parser/cpdf_document.cpp View 1 chunk +3 lines, -2 lines 2 comments Download

Messages

Total messages: 7 (3 generated)
Lei Zhang
https://codereview.chromium.org/2003873002/diff/1/core/fpdfapi/fpdf_parser/cpdf_document.cpp File core/fpdfapi/fpdf_parser/cpdf_document.cpp (right): https://codereview.chromium.org/2003873002/diff/1/core/fpdfapi/fpdf_parser/cpdf_document.cpp#newcode400 core/fpdfapi/fpdf_parser/cpdf_document.cpp:400: pdfium::ScopedSetInsertion<CPDF_Dictionary*> insertion(pVisited, pKid); Umm, not sure what happened here.
4 years, 7 months ago (2016-05-23 16:23:21 UTC) #2
Tom Sepez
lgtm https://codereview.chromium.org/2003873002/diff/1/core/fpdfapi/fpdf_parser/cpdf_document.cpp File core/fpdfapi/fpdf_parser/cpdf_document.cpp (right): https://codereview.chromium.org/2003873002/diff/1/core/fpdfapi/fpdf_parser/cpdf_document.cpp#newcode400 core/fpdfapi/fpdf_parser/cpdf_document.cpp:400: pdfium::ScopedSetInsertion<CPDF_Dictionary*> insertion(pVisited, pKid); On 2016/05/23 16:23:20, Lei Zhang ...
4 years, 7 months ago (2016-05-23 16:33:04 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2003873002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2003873002/1
4 years, 7 months ago (2016-05-23 16:48:44 UTC) #5
commit-bot: I haz the power
4 years, 7 months ago (2016-05-23 17:07:08 UTC) #7
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://pdfium.googlesource.com/pdfium/+/885bba0b002e2a70e7808e65a53d6f977ddc...

Powered by Google App Engine
This is Rietveld 408576698