Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(351)

Issue 2003863002: Issue 26466. Limited fix to pass on the dart:html test case. (Closed)

Created:
4 years, 7 months ago by scheglov
Modified:
4 years, 7 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Issue 26466. Limited fix to pass on the dart:html test case. Eventually we might want to go over all of the code and sprinkle it with checks like with to avoid re-resolving what we already know, and to avoid updating parts of element model which cannot be updated because the element model is resynthesized from a summary. R=brianwilkerson@google.com BUG= https://github.com/dart-lang/sdk/issues/26466 Committed: https://github.com/dart-lang/sdk/commit/41f8eaef19f8d28c7ff2e2f8ddaa94e8c8776e1c

Patch Set 1 #

Patch Set 2 : Rollback the SDK change. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+61 lines, -9 lines) Patch
M pkg/analyzer/lib/src/dart/element/element.dart View 5 chunks +44 lines, -0 lines 0 comments Download
M pkg/analyzer/lib/src/generated/resolver.dart View 2 chunks +17 lines, -9 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
scheglov
4 years, 7 months ago (2016-05-21 01:02:48 UTC) #1
Brian Wilkerson
lgtm > Eventually we might want to go over all of the code ... I'd ...
4 years, 7 months ago (2016-05-21 15:17:54 UTC) #2
scheglov
4 years, 7 months ago (2016-05-22 01:45:05 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
41f8eaef19f8d28c7ff2e2f8ddaa94e8c8776e1c (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698