Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2003853002:
Color emoji tests (Closed)
|
Created:
4 years, 7 months ago by Ilya Kulshin Modified:
4 years, 6 months ago CC:
chromium-reviews, blink-reviews Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionColor emoji tests
Add tests and Win10 expectations for color emoji.
Also fix an expectation for emoji fallback test to look for the color
emoji font first, which will be present on Win10, but not on Win7.
Skia change to enable color emoji on Win8.1+: https://codereview.chromium.org/1984943002/
BUG=333011
Committed: https://crrev.com/91e2b1e3000ac8da1328a5d1bf749ea4ffa7c763
Cr-Commit-Position: refs/heads/master@{#397752}
Patch Set 1 #Patch Set 2 : Revert DEPS change #
Messages
Total messages: 37 (24 generated)
Description was changed from ========== Emoji tests BUG= ========== to ========== Emoji tests Add tests and Win10 expectations for color emoji. Also fix an expectation for emoji fallback test to look for the color emoji font first, which will be present on Win10, but not on Win7. BUG=333011 ==========
Description was changed from ========== Emoji tests Add tests and Win10 expectations for color emoji. Also fix an expectation for emoji fallback test to look for the color emoji font first, which will be present on Win10, but not on Win7. BUG=333011 ========== to ========== Emoji tests Add tests and Win10 expectations for color emoji. Also fix an expectation for emoji fallback test to look for the color emoji font first, which will be present on Win10, but not on Win7. Skia change to enable color emoji on Win8.1+: https://codereview.chromium.org/1984943002/ BUG=333011 ==========
Description was changed from ========== Emoji tests Add tests and Win10 expectations for color emoji. Also fix an expectation for emoji fallback test to look for the color emoji font first, which will be present on Win10, but not on Win7. Skia change to enable color emoji on Win8.1+: https://codereview.chromium.org/1984943002/ BUG=333011 ========== to ========== Emoji tests Add tests and Win10 expectations for color emoji. Also fix an expectation for emoji fallback test to look for the color emoji font first, which will be present on Win10, but not on Win7. Skia change to enable color emoji on Win8.1+: https://codereview.chromium.org/1984943002/ BUG=333011 COMMIT=false ==========
Description was changed from ========== Emoji tests Add tests and Win10 expectations for color emoji. Also fix an expectation for emoji fallback test to look for the color emoji font first, which will be present on Win10, but not on Win7. Skia change to enable color emoji on Win8.1+: https://codereview.chromium.org/1984943002/ BUG=333011 COMMIT=false ========== to ========== Color emoji tests Add tests and Win10 expectations for color emoji. Also fix an expectation for emoji fallback test to look for the color emoji font first, which will be present on Win10, but not on Win7. Skia change to enable color emoji on Win8.1+: https://codereview.chromium.org/1984943002/ BUG=333011 COMMIT=false ==========
kulshin@chromium.org changed reviewers: + bungeman@chromium.org, reed@chromium.org, scottmg@chromium.org
ptal Please ignore the DEPS change; I will revert that file prior to landing.
lgtm
The CQ bit was checked by kulshin@chromium.org
The CQ bit was unchecked by kulshin@chromium.org
The CQ bit was unchecked by commit-bot@chromium.org
COMMIT=false detected. CQ is abandoning the patch.
The CQ bit was checked by kulshin@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from scottmg@chromium.org Link to the patchset: https://codereview.chromium.org/2003853002/#ps20001 (title: "Revert DEPS change")
The CQ bit was unchecked by commit-bot@chromium.org
Description was changed from ========== Color emoji tests Add tests and Win10 expectations for color emoji. Also fix an expectation for emoji fallback test to look for the color emoji font first, which will be present on Win10, but not on Win7. Skia change to enable color emoji on Win8.1+: https://codereview.chromium.org/1984943002/ BUG=333011 COMMIT=false ========== to ========== Color emoji tests Add tests and Win10 expectations for color emoji. Also fix an expectation for emoji fallback test to look for the color emoji font first, which will be present on Win10, but not on Win7. Skia change to enable color emoji on Win8.1+: https://codereview.chromium.org/1984943002/ BUG=333011 ==========
COMMIT=false detected. CQ is abandoning the patch.
The CQ bit was checked by kulshin@chromium.org
The CQ bit was unchecked by commit-bot@chromium.org
COMMIT=false detected. CQ is abandoning the patch.
Description was changed from ========== Color emoji tests Add tests and Win10 expectations for color emoji. Also fix an expectation for emoji fallback test to look for the color emoji font first, which will be present on Win10, but not on Win7. Skia change to enable color emoji on Win8.1+: https://codereview.chromium.org/1984943002/ BUG=333011 COMMIT=false ========== to ========== Color emoji tests Add tests and Win10 expectations for color emoji. Also fix an expectation for emoji fallback test to look for the color emoji font first, which will be present on Win10, but not on Win7. Skia change to enable color emoji on Win8.1+: https://codereview.chromium.org/1984943002/ BUG=333011 ==========
The CQ bit was checked by kulshin@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2003853002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2003853002/20001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by kulshin@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2003853002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2003853002/20001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by kulshin@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2003853002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2003853002/20001
The CQ bit was unchecked by kulshin@chromium.org
The CQ bit was checked by kulshin@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2003853002/20001
Message was sent while issue was closed.
Description was changed from ========== Color emoji tests Add tests and Win10 expectations for color emoji. Also fix an expectation for emoji fallback test to look for the color emoji font first, which will be present on Win10, but not on Win7. Skia change to enable color emoji on Win8.1+: https://codereview.chromium.org/1984943002/ BUG=333011 ========== to ========== Color emoji tests Add tests and Win10 expectations for color emoji. Also fix an expectation for emoji fallback test to look for the color emoji font first, which will be present on Win10, but not on Win7. Skia change to enable color emoji on Win8.1+: https://codereview.chromium.org/1984943002/ BUG=333011 ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== Color emoji tests Add tests and Win10 expectations for color emoji. Also fix an expectation for emoji fallback test to look for the color emoji font first, which will be present on Win10, but not on Win7. Skia change to enable color emoji on Win8.1+: https://codereview.chromium.org/1984943002/ BUG=333011 ========== to ========== Color emoji tests Add tests and Win10 expectations for color emoji. Also fix an expectation for emoji fallback test to look for the color emoji font first, which will be present on Win10, but not on Win7. Skia change to enable color emoji on Win8.1+: https://codereview.chromium.org/1984943002/ BUG=333011 Committed: https://crrev.com/91e2b1e3000ac8da1328a5d1bf749ea4ffa7c763 Cr-Commit-Position: refs/heads/master@{#397752} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/91e2b1e3000ac8da1328a5d1bf749ea4ffa7c763 Cr-Commit-Position: refs/heads/master@{#397752} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
