xfa/fgas/layout/fgas_rtfbreak.h - Issue 2003843002: Remove Release() from CFX_RTFBreak

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: xfa/fgas/layout/fgas_rtfbreak.h

Issue 2003843002: Remove Release() from CFX_RTFBreak (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: Consistent use of override. Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: xfa/fgas/layout/fgas_rtfbreak.h

diff --git a/xfa/fgas/layout/fgas_rtfbreak.h b/xfa/fgas/layout/fgas_rtfbreak.h

index 966950f26c3bf61865f15683c17f61d9d0f5d726..be3717f584b87041431cd7ff3706ea7fa39f1d85 100644

--- a/xfa/fgas/layout/fgas_rtfbreak.h

+++ b/xfa/fgas/layout/fgas_rtfbreak.h

@@ -246,7 +246,7 @@ class CFX_RTFBreak {

public:

CFX_RTFBreak(uint32_t dwPolicies);

~CFX_RTFBreak();

- void Release() { delete this; }

void SetLineBoundary(FX_FLOAT fLineStart, FX_FLOAT fLineEnd);

void SetLineStartPos(FX_FLOAT fLinePos);

uint32_t GetLayoutStyles() const { return m_dwLayoutStyles; }

« no previous file with comments | « no previous file | xfa/fxfa/app/xfa_textlayout.h » ('j') | no next file with comments »