Use unique_ptr in CPDF_CidFont

Use unique_ptr in CPDF_CidFont

Committed: https://pdfium.googlesource.com/pdfium/+/109975b30dbb2b047001a840b8a1e77434fce7b3

[Tom Sepez, 2016-05-20 23:33:18]

tsepez@chromium.org changed reviewers:
+ thestig@chromium.org

[Tom Sepez, 2016-05-20 23:33:19]

Lei, for review.

[Lei Zhang, 2016-05-20 23:41:29]

https://codereview.chromium.org/2003833003/diff/1/core/fpdfapi/fpdf_font/cpdf...
File core/fpdfapi/fpdf_font/cpdf_cidfont.h (right):

https://codereview.chromium.org/2003833003/diff/1/core/fpdfapi/fpdf_font/cpdf...
core/fpdfapi/fpdf_font/cpdf_cidfont.h:72: std::unique_ptr<CPDF_CMap>
m_pAllocatedCMap;
#include <memory>

https://codereview.chromium.org/2003833003/diff/1/core/fpdfapi/fpdf_font/cpdf...
core/fpdfapi/fpdf_font/cpdf_cidfont.h:78: std::unique_ptr<CPDF_StreamAcc>
m_pCIDToGIDMap;
This is a strangely named variable.

https://codereview.chromium.org/2003833003/diff/1/core/fpdfapi/fpdf_font/cpdf...
core/fpdfapi/fpdf_font/cpdf_cidfont.h:79: std::unique_ptr<uint16_t,
FxFreeDeleter> m_pAnsiWidths;
std::vector instead?

[Tom Sepez, 2016-05-23 18:09:44]

https://codereview.chromium.org/2003833003/diff/1/core/fpdfapi/fpdf_font/cpdf...
File core/fpdfapi/fpdf_font/cpdf_cidfont.h (right):

https://codereview.chromium.org/2003833003/diff/1/core/fpdfapi/fpdf_font/cpdf...
core/fpdfapi/fpdf_font/cpdf_cidfont.h:72: std::unique_ptr<CPDF_CMap>
m_pAllocatedCMap;
On 2016/05/20 23:41:28, Lei Zhang wrote:
> #include <memory>

Done.

https://codereview.chromium.org/2003833003/diff/1/core/fpdfapi/fpdf_font/cpdf...
core/fpdfapi/fpdf_font/cpdf_cidfont.h:78: std::unique_ptr<CPDF_StreamAcc>
m_pCIDToGIDMap;
On 2016/05/20 23:41:28, Lei Zhang wrote:
> This is a strangely named variable.

Yeah, really bugged me.  Renamed.

https://codereview.chromium.org/2003833003/diff/1/core/fpdfapi/fpdf_font/cpdf...
core/fpdfapi/fpdf_font/cpdf_cidfont.h:79: std::unique_ptr<uint16_t,
FxFreeDeleter> m_pAnsiWidths;
On 2016/05/20 23:41:28, Lei Zhang wrote:
> std::vector instead?

Done.

[Lei Zhang, 2016-05-23 18:32:26]

https://codereview.chromium.org/2003833003/diff/20001/core/fpdfapi/fpdf_font/...
File core/fpdfapi/fpdf_font/cpdf_cidfont.cpp (right):

https://codereview.chromium.org/2003833003/diff/20001/core/fpdfapi/fpdf_font/...
core/fpdfapi/fpdf_font/cpdf_cidfont.cpp:884: m_AnsiWidths[i] = 500;
Given the possible contents of |m_AnsiWidths|, we can replace it with a bool and
a simple helper function.

[Tom Sepez, 2016-05-23 19:24:19]

Done.

[Lei Zhang, 2016-05-23 19:28:27]

lgtm

https://codereview.chromium.org/2003833003/diff/60001/core/fpdfapi/fpdf_font/...
File core/fpdfapi/fpdf_font/cpdf_cidfont.cpp (right):

https://codereview.chromium.org/2003833003/diff/60001/core/fpdfapi/fpdf_font/...
core/fpdfapi/fpdf_font/cpdf_cidfont.cpp:210: m_bAnsiWidthsFixed(FALSE),
false

[Tom Sepez, 2016-05-23 20:07:38]

https://codereview.chromium.org/2003833003/diff/60001/core/fpdfapi/fpdf_font/...
File core/fpdfapi/fpdf_font/cpdf_cidfont.cpp (right):

https://codereview.chromium.org/2003833003/diff/60001/core/fpdfapi/fpdf_font/...
core/fpdfapi/fpdf_font/cpdf_cidfont.cpp:210: m_bAnsiWidthsFixed(FALSE),
On 2016/05/23 19:28:27, Lei Zhang wrote:
> false

Done.

[Tom Sepez, 2016-05-23 20:07:42]

The CQ bit was checked by tsepez@chromium.org

[Tom Sepez, 2016-05-23 20:07:42]

The patchset sent to the CQ was uploaded after l-g-t-m from thestig@chromium.org
Link to the patchset: https://codereview.chromium.org/2003833003/#ps80001
(title: "FALSE => false")

[commit-bot: I haz the power, 2016-05-23 20:07:49]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2003833003/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2003833003/80001

[commit-bot: I haz the power, 2016-05-23 20:28:47]

Description was changed from

==========
Use unique_ptr in CPDF_CidFont
==========

to

==========
Use unique_ptr in CPDF_CidFont

Committed:
https://pdfium.googlesource.com/pdfium/+/109975b30dbb2b047001a840b8a1e77434fc...
==========

[commit-bot: I haz the power, 2016-05-23 20:28:48]

Committed patchset #5 (id:80001) as
https://pdfium.googlesource.com/pdfium/+/109975b30dbb2b047001a840b8a1e77434fc...