Issue 2003813002: Dart: Rolls runtime forward.

Issue 2003813002: Dart: Rolls runtime forward. (Closed)

Created:
4 years, 7 months ago by zra

Modified:
4 years, 6 months ago

Reviewers:
Cutch, jeffbrown

CC:
mojo-reviews_chromium.org, gregsimon, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org

Base URL:
git@github.com:domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

More Reviews

Description

Dart: Rolls runtime forward. fixes #778 R=johnmccutchan@google.com Committed: https://chromium.googlesource.com/external/mojo/+/136367b988e1f8907ca127c30cccde29f2a1aea9

Patch Set 1 #

Patch Set 2 : Fix lint error #

Patch Set 3 : #

Patch Set 4 : Fix test #

Created: 4 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+12 lines, -3 lines)			Patch
M	DEPS	View		1 chunk	+1 line, -1 line	0 comments	Download
M	mojo/dart/embedder/io/file_patch.dart	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	mojo/tools/mojob.py	View	1 2	1 chunk	+2 lines, -0 lines	0 comments	Download
M	mojo/tools/mopy/gn.py	View	1 2	2 chunks	+3 lines, -0 lines	0 comments	Download
M	mojo/tools/mopy/gn_unittest.py	View	1 2 3	2 chunks	+2 lines, -0 lines	0 comments	Download
M	mojo/tools/mopy/paths.py	View	1 2	1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 7 (3 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

zra

Committed patchset #4 (id:60001) manually as 136367b988e1f8907ca127c30cccde29f2a1aea9 (presubmit successful).

4 years, 7 months ago (2016-05-23 18:08:38 UTC) #5

jeffbrown

4 years, 6 months ago (2016-05-25 01:18:35 UTC) #7

Message was sent while issue was closed.

I think this test might have broken the build.  I've done a gclient sync but I'm
still getting this:

ERROR at //build/config/BUILDCONFIG.gn:671:5: Source file not found.
    source_set(target_name) {
    ^------------------------
The target:
  //dart/third_party/boringssl:boringssl
has a source file:
  //dart/third_party/boringssl/src/ssl/t1_lib.c
which was not found.
ninja: error: rebuilding 'build.ninja': subcommand failed

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages