Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(174)

Side by Side Diff: chrome/browser/views/options/advanced_contents_view.cc

Issue 20038: Review request: fix 7324 and 7326: missing icon and wrong path in "download location" (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 11 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2006-2008 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2006-2008 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/views/options/advanced_contents_view.h" 5 #include "chrome/browser/views/options/advanced_contents_view.h"
6 6
7 #include <windows.h> 7 #include <windows.h>
8 8
9 #include <cryptuiapi.h> 9 #include <cryptuiapi.h>
10 #pragma comment(lib, "cryptui.lib") 10 #pragma comment(lib, "cryptui.lib")
(...skipping 673 matching lines...) Expand 10 before | Expand all | Expand 10 after
684 popup_blocked_notification_checkbox_ = new views::CheckBox( 684 popup_blocked_notification_checkbox_ = new views::CheckBox(
685 l10n_util::GetString(IDS_OPTIONS_SHOWPOPUPBLOCKEDNOTIFICATION)); 685 l10n_util::GetString(IDS_OPTIONS_SHOWPOPUPBLOCKEDNOTIFICATION));
686 popup_blocked_notification_checkbox_->SetListener(this); 686 popup_blocked_notification_checkbox_->SetListener(this);
687 687
688 if (l10n_util::GetTextDirection() == l10n_util::LEFT_TO_RIGHT) { 688 if (l10n_util::GetTextDirection() == l10n_util::LEFT_TO_RIGHT) {
689 gears_label_ = new views::Label( 689 gears_label_ = new views::Label(
690 l10n_util::GetString(IDS_OPTIONS_GEARSSETTINGS_GROUP_NAME)); 690 l10n_util::GetString(IDS_OPTIONS_GEARSSETTINGS_GROUP_NAME));
691 } else { 691 } else {
692 // Add an RTL mark so that 692 // Add an RTL mark so that
693 // ":" in "Google Gears:" in Hebrew Chrome is displayed left-most. 693 // ":" in "Google Gears:" in Hebrew Chrome is displayed left-most.
694 gears_label_ = new views::Label(l10n_util::GetString( 694 std::wstring gearssetting_group_name =
695 IDS_OPTIONS_GEARSSETTINGS_GROUP_NAME) + l10n_util::kRightToLeftMark); 695 l10n_util::GetString(IDS_OPTIONS_GEARSSETTINGS_GROUP_NAME);
696 gearssetting_group_name.push_back(
697 static_cast<wchar_t>(l10n_util::kRightToLeftMark));
698 gears_label_ = new views::Label(gearssetting_group_name);
696 } 699 }
697 gears_settings_button_ = new views::NativeButton( 700 gears_settings_button_ = new views::NativeButton(
698 l10n_util::GetString(IDS_OPTIONS_GEARSSETTINGS_CONFIGUREGEARS_BUTTON)); 701 l10n_util::GetString(IDS_OPTIONS_GEARSSETTINGS_CONFIGUREGEARS_BUTTON));
699 gears_settings_button_->SetListener(this); 702 gears_settings_button_->SetListener(this);
700 703
701 GridLayout* layout = new GridLayout(contents_); 704 GridLayout* layout = new GridLayout(contents_);
702 contents_->SetLayoutManager(layout); 705 contents_->SetLayoutManager(layout);
703 706
704 const int col_id = 0; 707 const int col_id = 0;
705 AddWrappingColumnSet(layout, col_id); 708 AddWrappingColumnSet(layout, col_id);
(...skipping 499 matching lines...) Expand 10 before | Expand all | Expand 10 after
1205 void AdvancedScrollViewContainer::Layout() { 1208 void AdvancedScrollViewContainer::Layout() {
1206 gfx::Rect lb = GetLocalBounds(false); 1209 gfx::Rect lb = GetLocalBounds(false);
1207 1210
1208 gfx::Size border = gfx::NativeTheme::instance()->GetThemeBorderSize( 1211 gfx::Size border = gfx::NativeTheme::instance()->GetThemeBorderSize(
1209 gfx::NativeTheme::LIST); 1212 gfx::NativeTheme::LIST);
1210 lb.Inset(border.width(), border.height()); 1213 lb.Inset(border.width(), border.height());
1211 scroll_view_->SetBounds(lb); 1214 scroll_view_->SetBounds(lb);
1212 scroll_view_->Layout(); 1215 scroll_view_->Layout();
1213 } 1216 }
1214 1217
OLDNEW
« no previous file with comments | « chrome/browser/bookmarks/bookmark_table_model.cc ('k') | chrome/browser/views/options/content_page_view.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698