Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(594)

Side by Side Diff: chrome/browser/bookmarks/bookmark_table_model.cc

Issue 20038: Review request: fix 7324 and 7326: missing icon and wrong path in "download location" (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 11 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | chrome/browser/views/options/advanced_contents_view.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2006-2008 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2006-2008 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/bookmarks/bookmark_table_model.h" 5 #include "chrome/browser/bookmarks/bookmark_table_model.h"
6 6
7 #include <limits> 7 #include <limits>
8 8
9 #include "base/string_util.h" 9 #include "base/string_util.h"
10 #include "base/time.h" 10 #include "base/time.h"
(...skipping 345 matching lines...) Expand 10 before | Expand all | Expand 10 after
356 if (node == model()->other_node()) { 356 if (node == model()->other_node()) {
357 *path = l10n_util::GetString(IDS_BOOKMARK_TABLE_OTHER_BOOKMARKS_PATH); 357 *path = l10n_util::GetString(IDS_BOOKMARK_TABLE_OTHER_BOOKMARKS_PATH);
358 return; 358 return;
359 } 359 }
360 BuildPath(node->GetParent(), path); 360 BuildPath(node->GetParent(), path);
361 path->append(l10n_util::GetString(IDS_BOOKMARK_TABLE_PATH_SEPARATOR)); 361 path->append(l10n_util::GetString(IDS_BOOKMARK_TABLE_PATH_SEPARATOR));
362 // Force path to have LTR directionality. Otherwise, folder path "CBA/FED" 362 // Force path to have LTR directionality. Otherwise, folder path "CBA/FED"
363 // (in which, "CBA" and "FED" stand for folder names in Hebrew, and "FED" is 363 // (in which, "CBA" and "FED" stand for folder names in Hebrew, and "FED" is
364 // a subfolder of "CBA") will be displayed as "FED/CBA". 364 // a subfolder of "CBA") will be displayed as "FED/CBA".
365 if (l10n_util::GetTextDirection() == l10n_util::RIGHT_TO_LEFT) { 365 if (l10n_util::GetTextDirection() == l10n_util::RIGHT_TO_LEFT) {
366 path->append(l10n_util::kLeftToRightMark); 366 path->push_back(static_cast<wchar_t>(l10n_util::kLeftToRightMark));
367 } 367 }
368 path->append(node->GetTitle()); 368 path->append(node->GetTitle());
369 } 369 }
OLDNEW
« no previous file with comments | « no previous file | chrome/browser/views/options/advanced_contents_view.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698