Fix remoting_unittests that are failing on 32-bit linux

Fix remoting_unittests that are failing on 32-bit linux

Failing tests:
https://bugs.chromium.org/p/chromium/issues/detail?id=613329#c1

BUG=613329
Committed: https://crrev.com/4e752e108394090a1d83f9054a862ffa60293346
Cr-Commit-Position: refs/heads/master@{#396543}

[Tom (Use chromium acct), 2016-05-20 19:20:48]

thomasanderson@google.com changed reviewers:
+ asanka@chromium.org, jamiewalch@chromium.org, phajdan.jr@chromium.org

[Tom (Use chromium acct), 2016-05-20 19:20:55]

The CQ bit was checked by thomasanderson@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-05-20 19:21:10]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2003753002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2003753002/1

[Dirk Pranke, 2016-05-20 19:47:42]

dpranke@chromium.org changed reviewers:
+ dpranke@chromium.org

[Dirk Pranke, 2016-05-20 19:47:43]

I'm puzzled why any of these changes would be needed for 32-bit linux
specifically. Any ideas?

[commit-bot: I haz the power, 2016-05-20 19:56:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-20 19:56:38]

Dry run: Try jobs failed on following builders:
  android_arm64_dbg_recipe on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...)

[Jamie, 2016-05-20 20:27:35]

remoting/ LGTM.

Can you add a link to a failing build to the CL description for reference?

https://codereview.chromium.org/2003753002/diff/1/remoting/host/security_key/...
File remoting/host/security_key/remote_security_key_ipc_constants.h (right):

https://codereview.chromium.org/2003753002/diff/1/remoting/host/security_key/...
remoting/host/security_key/remote_security_key_ipc_constants.h:24: // the
current directly.
s/directly/directory/

[Tom (Use chromium acct), 2016-05-20 21:31:01]

On 2016/05/20 19:47:43, Dirk Pranke wrote:
> I'm puzzled why any of these changes would be needed for 32-bit linux
> specifically. Any ideas?

I'm not sure either :S  But, without the change, all of the tests pass on my
64-bit goobuntu machine, yet fail on my 32-bit ubuntu 12.04 guest OS.  At least
for the glib changes, there might be an older version of glib that's used on
12.04?

On 2016/05/20 20:27:35, Jamie wrote:
> remoting/ LGTM.
> 
> Can you add a link to a failing build to the CL description for reference?
> 

https://bugs.chromium.org/p/chromium/issues/detail?id=613329#c1

https://codereview.chromium.org/2003753002/diff/1/remoting/host/security_key/...
File remoting/host/security_key/remote_security_key_ipc_constants.h (right):

https://codereview.chromium.org/2003753002/diff/1/remoting/host/security_key/...
remoting/host/security_key/remote_security_key_ipc_constants.h:24: // the
current directly.
On 2016/05/20 20:27:34, Jamie wrote:
> s/directly/directory/

Done.

[Dirk Pranke, 2016-05-20 21:46:23]

ok. lgtm.

[Dirk Pranke, 2016-05-20 23:03:06]

https://codereview.chromium.org/2003753002/diff/1/remoting/host/BUILD.gn
File remoting/host/BUILD.gn (right):

https://codereview.chromium.org/2003753002/diff/1/remoting/host/BUILD.gn#newc...
remoting/host/BUILD.gn:335: "security_key/remote_security_key_ipc_constants.cc",
you don't need to add the ipc_constants.cc file here, because it should already
be being
pulled into the :host target via the list of sources in the gypi file, above
(line 73).

[Tom (Use chromium acct), 2016-05-20 23:13:51]

The CQ bit was checked by thomasanderson@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-05-20 23:14:26]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2003753002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2003753002/40001

[commit-bot: I haz the power, 2016-05-21 00:27:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-21 00:27:08]

Dry run: This issue passed the CQ dry run.

[Tom (Use chromium acct), 2016-05-21 03:40:34]

Description was changed from

==========
Fix remoting_unittests that are failing on 32-bit linux

BUG=613329
==========

to

==========
Fix remoting_unittests that are failing on 32-bit linux

Failing tests:
https://bugs.chromium.org/p/chromium/issues/detail?id=613329#c1

BUG=613329
==========

[joedow, 2016-05-21 16:27:45]

joedow@chromium.org changed reviewers:
+ joedow@chromium.org

[joedow, 2016-05-21 16:27:46]

lgtm

[Tom (Use chromium acct), 2016-05-24 22:04:10]

Pinging asanka@ for src/net OWNERS approval.

[Paweł Hajdan Jr., 2016-05-25 01:42:13]

g_type_init changes LGTM

[asanka, 2016-05-25 02:10:21]

The g_type_init changes should go in a separate CL. They are unrelated to the
IPC changes.

Also, can you pull out the crash stacks and call them out on the bug? Can you
also add a note explaining why remoting requires //net call g_type_init()?

[Tom (Use chromium acct), 2016-05-27 16:37:38]

The CQ bit was checked by thomasanderson@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-05-27 16:37:48]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2003753002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2003753002/60001

[commit-bot: I haz the power, 2016-05-27 17:40:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-27 17:40:58]

Dry run: This issue passed the CQ dry run.

[Tom (Use chromium acct), 2016-05-27 19:53:28]

The CQ bit was checked by thomasanderson@google.com

[Tom (Use chromium acct), 2016-05-27 19:53:28]

The patchset sent to the CQ was uploaded after l-g-t-m from
jamiewalch@chromium.org, dpranke@chromium.org, joedow@chromium.org,
phajdan.jr@chromium.org
Link to the patchset: https://codereview.chromium.org/2003753002/#ps60001
(title: "Removed g_type_init changes")

[commit-bot: I haz the power, 2016-05-27 19:53:56]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2003753002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2003753002/60001

[commit-bot: I haz the power, 2016-05-27 19:58:21]

Description was changed from

==========
Fix remoting_unittests that are failing on 32-bit linux

Failing tests:
https://bugs.chromium.org/p/chromium/issues/detail?id=613329#c1

BUG=613329
==========

to

==========
Fix remoting_unittests that are failing on 32-bit linux

Failing tests:
https://bugs.chromium.org/p/chromium/issues/detail?id=613329#c1

BUG=613329
==========

[commit-bot: I haz the power, 2016-05-27 19:58:23]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-05-27 19:59:50]

Description was changed from

==========
Fix remoting_unittests that are failing on 32-bit linux

Failing tests:
https://bugs.chromium.org/p/chromium/issues/detail?id=613329#c1

BUG=613329
==========

to

==========
Fix remoting_unittests that are failing on 32-bit linux

Failing tests:
https://bugs.chromium.org/p/chromium/issues/detail?id=613329#c1

BUG=613329

Committed: https://crrev.com/4e752e108394090a1d83f9054a862ffa60293346
Cr-Commit-Position: refs/heads/master@{#396543}
==========

[commit-bot: I haz the power, 2016-05-27 19:59:51]

Patchset 4 (id:??) landed as
https://crrev.com/4e752e108394090a1d83f9054a862ffa60293346
Cr-Commit-Position: refs/heads/master@{#396543}