Issue 200373003: Oilpan: make DataObject and SharedWorker heap Supplementables.

Issue 200373003: Oilpan: make DataObject and SharedWorker heap Supplementables. (Closed)

Created:
6 years, 9 months ago by sof

Modified:
6 years, 9 months ago

Reviewers:
oilpan-reviews, haraken

CC:
blink-reviews, kinuko, tzik, nhiroki, falken, horo+watch_chromium.org, kinuko+watch

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Visibility:
Public.

More Reviews

Description

Oilpan: make DataObject and SharedWorker heap Supplementables. With heap supplement{able}s support now in place, follow up and turn the supplements of these two into garbage allocated objects also. R=haraken@chromium.org BUG=340522 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=169733

Patch Set 1 #

Total comments: 4

Patch Set 2 : Add missing HeapSupplementable<> trace() calls #

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+36 lines, -11 lines)			Patch
M	Source/core/clipboard/DataObject.h	View	1	2 chunks	+2 lines, -2 lines	0 comments	Download
M	Source/core/clipboard/DataObject.cpp	View	1	1 chunk	+3 lines, -0 lines	0 comments	Download
M	Source/core/workers/SharedWorker.h	View		1 chunk	+2 lines, -1 line	0 comments	Download
M	Source/core/workers/SharedWorker.cpp	View	1	1 chunk	+3 lines, -0 lines	0 comments	Download
M	Source/modules/filesystem/DraggedIsolatedFileSystem.h	View		2 chunks	+9 lines, -5 lines	0 comments	Download
M	Source/modules/filesystem/DraggedIsolatedFileSystem.cpp	View		1 chunk	+10 lines, -0 lines	0 comments	Download
M	Source/modules/performance/SharedWorkerPerformance.h	View		3 chunks	+5 lines, -1 line	0 comments	Download
M	Source/modules/performance/SharedWorkerPerformance.cpp	View		1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

haraken

LGTM with comments. https://codereview.chromium.org/200373003/diff/1/Source/core/clipboard/DataObject.h File Source/core/clipboard/DataObject.h (right): https://codereview.chromium.org/200373003/diff/1/Source/core/clipboard/DataObject.h#newcode100 Source/core/clipboard/DataObject.h:100: void trace(Visitor*); Ditto. Also you can ...

6 years, 9 months ago (2014-03-21 10:35:12 UTC) #2

sof

https://codereview.chromium.org/200373003/diff/1/Source/core/clipboard/DataObject.h File Source/core/clipboard/DataObject.h (right): https://codereview.chromium.org/200373003/diff/1/Source/core/clipboard/DataObject.h#newcode100 Source/core/clipboard/DataObject.h:100: void trace(Visitor*); On 2014/03/21 10:35:13, haraken wrote: > > ...

6 years, 9 months ago (2014-03-21 10:42:19 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sigbjornf@opera.com/200373003/20001

6 years, 9 months ago (2014-03-21 10:45:21 UTC) #5

Message was sent while issue was closed.

Change committed as 169733

Expand Messages | Collapse Messages