Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(266)

Issue 2003703002: Fix isolate_tests for app_list_presenter_unittests (Closed)

Created:
4 years, 7 months ago by hans
Modified:
4 years, 7 months ago
Reviewers:
Dirk Pranke, tapted
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix isolate_tests for app_list_presenter_unittests After https://codereview.chromium.org/1934213002/ enable_app_list is on longer set on Linux, and the condition for building app_list_presenter_unittests is now only "use_aura==1". Update gn_migration.gypi accordingly to make app_list_presenter_unittests_run part of "all" when app_list_presenter_unittests is. BUG=600915 R=dpranke@chromium.org Committed: https://chromium.googlesource.com/chromium/src/+/54fbd40e15a5f19df183e01caac9289f82a03d91

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M build/gn_migration.gypi View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (4 generated)
hans
Please take a look.
4 years, 7 months ago (2016-05-20 17:19:57 UTC) #2
Dirk Pranke
lgtm
4 years, 7 months ago (2016-05-20 17:21:16 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2003703002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2003703002/1
4 years, 7 months ago (2016-05-20 17:23:23 UTC) #5
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/54fbd40e15a5f19df183e01caac9289f82a03d91 Cr-Commit-Position: refs/heads/master@{#395144}
4 years, 7 months ago (2016-05-20 20:01:05 UTC) #7
hans
4 years, 7 months ago (2016-05-20 20:01:50 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
54fbd40e15a5f19df183e01caac9289f82a03d91 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698