Issue 20037002: Fix app shim focus.

Issue 20037002: Fix app shim focus. (Closed)

Created:
7 years, 5 months ago by jackhou1

Modified:
7 years, 5 months ago

Reviewers:
tapted, benwells, Nico

CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org, tfarina, erikwright+watch_chromium.org, extensions-reviews_chromium.org, chromium-apps-reviews_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Fix app shim focus. When launching an app from Chrome, start the app shim without activating it. In case the app was launched from the shim, focus the app when its first window opens. BUG=263217 TEST=Start an app from the NTP. The shim should start without stealing focus. Quit and restart the app from the shim. The app's first window should take focus. Close the window and click the app's dock icon. A new window should open and take focus. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=213405

Patch Set 1 #

Total comments: 2

Patch Set 2 : Address comment #

Patch Set 3 : Sync and rebase #

Created: 7 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+14 lines, -5 lines)			Patch
M	apps/app_shim/chrome_main_app_mode_mac.mm	View	1 2	1 chunk	+1 line, -0 lines	0 comments	Download
M	apps/app_shim/extension_app_shim_handler_mac.cc	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	apps/app_shim/extension_app_shim_handler_mac_unittest.cc	View		1 chunk	+3 lines, -1 line	0 comments	Download
M	base/mac/launch_services_util.h	View		2 chunks	+4 lines, -0 lines	0 comments	Download
M	base/mac/launch_services_util.cc	View	1	3 chunks	+2 lines, -3 lines	0 comments	Download
M	chrome/browser/web_applications/web_app_mac.mm	View	1 2	1 chunk	+3 lines, -1 line	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

tapted

lgtm https://codereview.chromium.org/20037002/diff/1/base/mac/launch_services_util.cc File base/mac/launch_services_util.cc (right): https://codereview.chromium.org/20037002/diff/1/base/mac/launch_services_util.cc#newcode7 base/mac/launch_services_util.cc:7: #include <ApplicationServices/ApplicationServices.h> nit: this include is redundant now

7 years, 5 months ago (2013-07-23 11:08:28 UTC) #2

jackhou1

benwells, please review for OWNERS in chrome/browser/web_applications/ thakis, please review for OWNERS in base/mac/ https://codereview.chromium.org/20037002/diff/1/base/mac/launch_services_util.cc ...

7 years, 5 months ago (2013-07-23 12:13:16 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jackhou@chromium.org/20037002/9001

7 years, 5 months ago (2013-07-24 04:36:59 UTC) #6

Message was sent while issue was closed.

Change committed as 213405

Expand Messages | Collapse Messages