Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2897)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2003673003: [Offline pages] Fixing website settings crash (Closed)

Created:
4 years, 7 months ago by fgorski
Modified:
4 years, 7 months ago
Reviewers:
chili
CC:
chromium-reviews, romax+watch_chromium.org, fgorski+watch_chromium.org, dewittj+watch_chromium.org, petewil+watch_chromium.org, chili+watch_chromium.org, dimich+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Offline pages] Fixing website settings crash * Removing annotation that prevents jni from finding the method. BUG=613700 Committed: https://crrev.com/c61217944d70f81ef03b7921ed02624038ca69e8 Cr-Commit-Position: refs/heads/master@{#395204}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -3 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/offlinepages/OfflinePageBridge.java View 2 chunks +1 line, -3 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
fgorski
PTAL
4 years, 7 months ago (2016-05-20 21:41:25 UTC) #2
chili
lgtm Interesting. So no @Nullable in JNI functions?
4 years, 7 months ago (2016-05-20 22:09:48 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2003673003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2003673003/1
4 years, 7 months ago (2016-05-20 22:25:50 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-20 23:38:25 UTC) #6
commit-bot: I haz the power
4 years, 7 months ago (2016-05-20 23:41:07 UTC) #8
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/c61217944d70f81ef03b7921ed02624038ca69e8
Cr-Commit-Position: refs/heads/master@{#395204}

Powered by Google App Engine
This is Rietveld 408576698