Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(423)

Issue 2003663002: [turbofan] Better handling of inserted split-edge blocks (Closed)

Created:
4 years, 7 months ago by danno
Modified:
4 years, 7 months ago
Reviewers:
Michael Starzinger
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Better handling of inserted split-edge blocks Previously, split-edge blocks inserted into CodeStubAssembler schedules inherited the "deferredness" of their predecessor block. This tended to inline newly inserted blocks that preceeded deferred code inline with non-deferred code. The stack frame elider sometimes inserted stack construction into these blocks, code which was actually was only needed in the deferred case. This CL marks inserted split edge blocks with the deferredness of their successors, e.g. they are defererred if their predecessor is deferrred. This moves stack building code that logically belongs to deferred code into the deferred code area rather than inlining it in non-deferred code. Committed: https://crrev.com/6eb242eebbc06ab171d86a9b2e4bfe60d4df3667 Cr-Commit-Position: refs/heads/master@{#36446}

Patch Set 1 #

Patch Set 2 : Remove rogue file #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/compiler/schedule.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
danno
ptal
4 years, 7 months ago (2016-05-20 16:21:48 UTC) #2
Michael Starzinger
LGTM (rubber-stamped).
4 years, 7 months ago (2016-05-23 13:18:41 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2003663002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2003663002/20001
4 years, 7 months ago (2016-05-23 14:08:53 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 7 months ago (2016-05-23 14:47:03 UTC) #6
commit-bot: I haz the power
4 years, 7 months ago (2016-05-23 14:47:34 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/6eb242eebbc06ab171d86a9b2e4bfe60d4df3667
Cr-Commit-Position: refs/heads/master@{#36446}

Powered by Google App Engine
This is Rietveld 408576698