Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2003643002:
Disable these tests only on debug build. They're expected to fail on debug build. (Closed)
|
Created:
4 years, 7 months ago by oshima Modified:
4 years, 7 months ago Reviewers:
kjellander_chromium CC:
chromium-reviews, blink-reviews Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionDisable these tests only on debug build. They're expected to fail on debug build.
BUG=593567
Committed: https://crrev.com/aaf3b898c1665889c3aed2d0e439f6ec74c1bdc5
Cr-Commit-Position: refs/heads/master@{#395147}
Patch Set 1 #Patch Set 2 : #Messages
Total messages: 23 (13 generated)
The CQ bit was checked by oshima@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2003643002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2003643002/1
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by oshima@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2003643002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2003643002/20001
Description was changed from ========== Fix TestExpectation BUG= ========== to ========== Fix TestExpectation BUG=593567 ==========
oshima@chromium.org changed reviewers: + kjellander@chromium.org
Description was changed from ========== Fix TestExpectation BUG=593567 ========== to ========== Enable these tests only on debug build. They're expected to fail on debug build. BUG=593567 ==========
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
lgtm but I'm not a WebKit owner nor knows anything about these tests (if I showed up in git blame it's because I've been doing changes as Chrome sheriff)
The CQ bit was checked by oshima@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2003643002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2003643002/20001
On 2016/05/20 20:00:20, kjellander (chromium) wrote: > lgtm but I'm not a WebKit owner nor knows anything about these tests (if I > showed up in git blame it's because I've been doing changes as Chrome sheriff) Thanks. No onwer for TestExpectation. Just wanted second-eye review.
Message was sent while issue was closed.
Description was changed from ========== Enable these tests only on debug build. They're expected to fail on debug build. BUG=593567 ========== to ========== Enable these tests only on debug build. They're expected to fail on debug build. BUG=593567 ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== Enable these tests only on debug build. They're expected to fail on debug build. BUG=593567 ========== to ========== Enable these tests only on debug build. They're expected to fail on debug build. BUG=593567 Committed: https://crrev.com/aaf3b898c1665889c3aed2d0e439f6ec74c1bdc5 Cr-Commit-Position: refs/heads/master@{#395147} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/aaf3b898c1665889c3aed2d0e439f6ec74c1bdc5 Cr-Commit-Position: refs/heads/master@{#395147}
Message was sent while issue was closed.
Description was changed from ========== Enable these tests only on debug build. They're expected to fail on debug build. BUG=593567 Committed: https://crrev.com/aaf3b898c1665889c3aed2d0e439f6ec74c1bdc5 Cr-Commit-Position: refs/heads/master@{#395147} ========== to ========== Disable these tests only on debug build. They're expected to fail on debug build. BUG=593567 Committed: https://crrev.com/aaf3b898c1665889c3aed2d0e439f6ec74c1bdc5 Cr-Commit-Position: refs/heads/master@{#395147} ==========
Message was sent while issue was closed.
Patchset #4 (id:60001) has been deleted
Message was sent while issue was closed.
Patchset #3 (id:40001) has been deleted |
