third_party/WebKit/Source/core/html/track/vtt/VTTScanner.h - Issue 2003543002: media/track: Replace wtf/Assertions.h macros in favor of base/logging.h macros

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/html/track/vtt/VTTScanner.h

Issue 2003543002: media/track: Replace wtf/Assertions.h macros in favor of base/logging.h macros (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/html/track/vtt/VTTCue.cpp ('K') | « third_party/WebKit/Source/core/html/track/vtt/VTTRegion.cpp ('k') | third_party/WebKit/Source/core/html/track/vtt/VTTScanner.cpp » ('j') | third_party/WebKit/Source/core/html/track/vtt/VTTScanner.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/html/track/vtt/VTTScanner.h

diff --git a/third_party/WebKit/Source/core/html/track/vtt/VTTScanner.h b/third_party/WebKit/Source/core/html/track/vtt/VTTScanner.h

index b250eb5ea90becb9bf4495d4043df1e5c4c86d23..8ceeaf512c0d45717c1f7303672ed58132464c5c 100644

--- a/third_party/WebKit/Source/core/html/track/vtt/VTTScanner.h

+++ b/third_party/WebKit/Source/core/html/track/vtt/VTTScanner.h

@@ -216,19 +216,19 @@ inline VTTScanner::Run VTTScanner::collectUntil()

inline void VTTScanner::seekTo(Position position)

{

- ASSERT(position <= end());

+ DCHECK(position <= end());

fs 2016/05/20 13:01:07 DCHECK_LE?

Srirama 2016/05/20 14:15:41 Done.

m_data.characters8 = position;

}

inline UChar VTTScanner::currentChar() const

{

- ASSERT(getPosition() < end());

+ DCHECK(getPosition() < end());

fs 2016/05/20 13:01:07 DCHECK_LT?

Srirama 2016/05/20 14:15:41 Done.

return m_is8Bit ? *m_data.characters8 : *m_data.characters16;

}

inline void VTTScanner::advance(unsigned amount)

{

- ASSERT(getPosition() < end());

+ DCHECK(getPosition() < end());

fs 2016/05/20 13:01:07 Ditto.

Srirama 2016/05/20 14:15:41 Done.

if (m_is8Bit)

m_data.characters8 += amount;

else