Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(86)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2003543002: media/track: Replace wtf/Assertions.h macros in favor of base/logging.h macros (Closed)

Created:
4 years, 7 months ago by Srirama
Modified:
4 years, 7 months ago
Reviewers:
fs
CC:
blink-reviews, blink-reviews-html_chromium.org, chromium-reviews, dglazkov+blink, eric.carlson_apple.com, feature-media-reviews_chromium.org, gasubic, mlamouri+watch-blink_chromium.org, philipj_slow, nessy, vcarbune.chromium
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

media/track: Replace wtf/Assertions.h macros in favor of base/logging.h macros Replaced wtf/Assertions.h macros in favor of base/logging.h macros in core/html/track folder. ASSERT, ASSERT_UNUSED -> DCHECK ASSERT_NOT_REACHED -> NOTREACHED ASSERT_WITH_SECURITY_IMPLICATION -> SECURITY_DCHECK BUG=596522 Committed: https://crrev.com/63fee82a587cce7057768670d4b98a6d1660f515 Cr-Commit-Position: refs/heads/master@{#395078}

Patch Set 1 #

Patch Set 2 : Rebase #

Total comments: 28

Patch Set 3 : address comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+94 lines, -96 lines) Patch
M third_party/WebKit/Source/core/html/track/AutomaticTrackSelection.cpp View 1 2 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/html/track/CueTimeline.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/track/CueTimeline.cpp View 1 2 5 chunks +5 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/html/track/InbandTextTrack.cpp View 1 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/html/track/TextTrack.cpp View 1 2 8 chunks +10 lines, -11 lines 0 comments Download
M third_party/WebKit/Source/core/html/track/TextTrackContainer.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/track/TextTrackCue.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/track/TextTrackCueList.cpp View 1 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/html/track/TextTrackList.cpp View 1 2 7 chunks +8 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/core/html/track/TrackEvent.cpp View 1 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/html/track/TrackListBase.h View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/track/VideoTrackList.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/track/vtt/BufferedLineReader.h View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/html/track/vtt/BufferedLineReader.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/track/vtt/VTTCue.cpp View 1 2 19 chunks +23 lines, -24 lines 0 comments Download
M third_party/WebKit/Source/core/html/track/vtt/VTTElement.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/html/track/vtt/VTTParser.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/html/track/vtt/VTTRegion.cpp View 1 4 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/html/track/vtt/VTTScanner.h View 1 2 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/html/track/vtt/VTTScanner.cpp View 1 2 2 chunks +11 lines, -11 lines 0 comments Download
M third_party/WebKit/Source/core/html/track/vtt/VTTTokenizer.cpp View 5 chunks +6 lines, -6 lines 0 comments Download

Messages

Total messages: 18 (8 generated)
Srirama
PTAL
4 years, 7 months ago (2016-05-20 11:59:30 UTC) #4
fs
Maybe s/media/track/ in the subject? (Or media/track) https://codereview.chromium.org/2003543002/diff/20001/third_party/WebKit/Source/core/html/track/AutomaticTrackSelection.cpp File third_party/WebKit/Source/core/html/track/AutomaticTrackSelection.cpp (right): https://codereview.chromium.org/2003543002/diff/20001/third_party/WebKit/Source/core/html/track/AutomaticTrackSelection.cpp#newcode183 third_party/WebKit/Source/core/html/track/AutomaticTrackSelection.cpp:183: DCHECK(kind == ...
4 years, 7 months ago (2016-05-20 13:01:07 UTC) #5
Srirama
https://codereview.chromium.org/2003543002/diff/20001/third_party/WebKit/Source/core/html/track/AutomaticTrackSelection.cpp File third_party/WebKit/Source/core/html/track/AutomaticTrackSelection.cpp (right): https://codereview.chromium.org/2003543002/diff/20001/third_party/WebKit/Source/core/html/track/AutomaticTrackSelection.cpp#newcode183 third_party/WebKit/Source/core/html/track/AutomaticTrackSelection.cpp:183: DCHECK(kind == TextTrack::metadataKeyword()); On 2016/05/20 13:01:07, fs wrote: > ...
4 years, 7 months ago (2016-05-20 14:15:41 UTC) #8
fs
lgtm
4 years, 7 months ago (2016-05-20 14:20:56 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2003543002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2003543002/40001
4 years, 7 months ago (2016-05-20 15:39:38 UTC) #11
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 7 months ago (2016-05-20 15:44:17 UTC) #13
commit-bot: I haz the power
Patchset 3 (id:??) landed as https://crrev.com/63fee82a587cce7057768670d4b98a6d1660f515 Cr-Commit-Position: refs/heads/master@{#395078}
4 years, 7 months ago (2016-05-20 15:45:53 UTC) #15
gogerald1
A revert of this CL (patchset #3 id:40001) has been created in https://codereview.chromium.org/1999813002/ by gogerald@chromium.org. ...
4 years, 7 months ago (2016-05-20 16:06:50 UTC) #16
fs
On 2016/05/20 at 16:06:50, gogerald wrote: > A revert of this CL (patchset #3 id:40001) ...
4 years, 7 months ago (2016-05-20 17:13:26 UTC) #17
Srirama
4 years, 7 months ago (2016-05-21 05:29:30 UTC) #18
Message was sent while issue was closed. 
On 2016/05/20 17:13:26, fs wrote:
> On 2016/05/20 at 16:06:50, gogerald wrote:
> > A revert of this CL (patchset #3 id:40001) has been created in
> https://codereview.chromium.org/1999813002/ by mailto:gogerald@chromium.org.
> > 
> > The reason for reverting is: Crash build
> http://build.chromium.org/p/chromium.mac/builders/Mac%20Builder/builds/44237.
> > 
> >
>
https://chromium.googlesource.com/chromium/src/+blame/master/third_party/WebK...
> > 
> > DCHECKs are removed from Release build..
> 
> Doh! Sorry Srirama, my bad. (It sucks that none of the trybots build a config
> like the one above though =/)

No problem fs, i will fix the compile error and land it on monday.

Powered by Google App Engine
This is Rietveld 408576698