arc: Register media files to MediaProvider.

arc: Register media files to MediaProvider.

ArcDownloadsWatcherService will watch Downloads directory to:
- register newly created media files to MediaProvider,
- remove removed media files from MediaProvider.

mojom is added in this change:
https://codereview.chromium.org/1996933002/

Corresponding ARC changes: ag/1059173, ag/1058841, ag/1059172

BUG=b/28755411
TEST=Manually tested

Committed: https://crrev.com/77d98aa9bd1800410c21193a969c6f987cf63fe3
Cr-Commit-Position: refs/heads/master@{#395860}

[Shuhei Takahashi, 2016-05-20 10:56:14]

Description was changed from

==========
arc: Register media files to MediaProvider.

ArcDownloadsWatcherService will watch Downloads directory to:
- register newly created media files to MediaProvider,
- remove removed media files from MediaProvider.

BUG=b/28755411
TEST=Manually tested
==========

to

==========
arc: Register media files to MediaProvider.

ArcDownloadsWatcherService will watch Downloads directory to:
- register newly created media files to MediaProvider,
- remove removed media files from MediaProvider.

BUG=b/28755411
TEST=Manually tested
==========

[Shuhei Takahashi, 2016-05-20 11:00:10]

Description was changed from

==========
arc: Register media files to MediaProvider.

ArcDownloadsWatcherService will watch Downloads directory to:
- register newly created media files to MediaProvider,
- remove removed media files from MediaProvider.

BUG=b/28755411
TEST=Manually tested
==========

to

==========
arc: Register media files to MediaProvider.

ArcDownloadsWatcherService will watch Downloads directory to:
- register newly created media files to MediaProvider,
- remove removed media files from MediaProvider.

mojom is added in this change:
https://codereview.chromium.org/2003533002/

Corresponding ARC changes: ag/1059173, ag/1058841, ag/1059172


BUG=b/28755411
TEST=Manually tested
==========

[Shuhei Takahashi, 2016-05-20 11:00:22]

Description was changed from

==========
arc: Register media files to MediaProvider.

ArcDownloadsWatcherService will watch Downloads directory to:
- register newly created media files to MediaProvider,
- remove removed media files from MediaProvider.

mojom is added in this change:
https://codereview.chromium.org/2003533002/

Corresponding ARC changes: ag/1059173, ag/1058841, ag/1059172


BUG=b/28755411
TEST=Manually tested
==========

to

==========
arc: Register media files to MediaProvider.

ArcDownloadsWatcherService will watch Downloads directory to:
- register newly created media files to MediaProvider,
- remove removed media files from MediaProvider.

mojom is added in this change:
https://codereview.chromium.org/2003533002/

Corresponding ARC changes: ag/1059173, ag/1058841, ag/1059172

BUG=b/28755411
TEST=Manually tested
==========

[Shuhei Takahashi, 2016-05-20 11:06:23]

nya@chromium.org changed reviewers:
+ lhchavez@chromium.org, oshima@chromium.org

[Shuhei Takahashi, 2016-05-20 11:06:24]

lhchavez: PTAL

oshima: PTAL for .gypi

[Luis Héctor Chávez, 2016-05-20 15:18:59]

just nits.

https://codereview.chromium.org/2003533002/diff/40001/chrome/browser/chromeos...
File chrome/browser/chromeos/arc/arc_downloads_watcher_service.cc (right):

https://codereview.chromium.org/2003533002/diff/40001/chrome/browser/chromeos...
chrome/browser/chromeos/arc/arc_downloads_watcher_service.cc:128:
watcher_.reset(new base::FilePathWatcher());
nit: watcher_ = base::MakeUnique<FilePathWatcher>();

https://codereview.chromium.org/2003533002/diff/40001/chrome/browser/chromeos...
chrome/browser/chromeos/arc/arc_downloads_watcher_service.cc:160: for (;;) {
nit: for (const base::FilePath& cros_path = enumerator.Next();
          !cros_path.empty();
          cros_path = enumerator.Next())

seems to be more idiomatic.

https://codereview.chromium.org/2003533002/diff/40001/chrome/browser/chromeos...
File chrome/browser/chromeos/arc/arc_downloads_watcher_service.h (right):

https://codereview.chromium.org/2003533002/diff/40001/chrome/browser/chromeos...
chrome/browser/chromeos/arc/arc_downloads_watcher_service.h:39: void
StartWatchDownloads();
nit: StartWatchingDownloads() or StartDownloadsWatch(). Same below.

[oshima, 2016-05-20 17:24:41]

I don't think you need my review in gypi file.

[oshima, 2016-05-20 17:24:54]

oshima@chromium.org changed reviewers:
- oshima@chromium.org

[Shuhei Takahashi, 2016-05-24 08:46:34]

lhchavez: PTAL

oshima: Oops, sorry I don't know well about OWNERS file syntax... :(

https://codereview.chromium.org/2003533002/diff/40001/chrome/browser/chromeos...
File chrome/browser/chromeos/arc/arc_downloads_watcher_service.cc (right):

https://codereview.chromium.org/2003533002/diff/40001/chrome/browser/chromeos...
chrome/browser/chromeos/arc/arc_downloads_watcher_service.cc:128:
watcher_.reset(new base::FilePathWatcher());
On 2016/05/20 15:18:59, Luis Héctor Chávez (slow 5-23) wrote:
> nit: watcher_ = base::MakeUnique<FilePathWatcher>();

Done.

https://codereview.chromium.org/2003533002/diff/40001/chrome/browser/chromeos...
chrome/browser/chromeos/arc/arc_downloads_watcher_service.cc:160: for (;;) {
On 2016/05/20 15:18:59, Luis Héctor Chávez (slow 5-23) wrote:
> nit: for (const base::FilePath& cros_path = enumerator.Next();
>           !cros_path.empty();
>           cros_path = enumerator.Next())
> 
> seems to be more idiomatic.

Done, but I made |cros_path| non-reference to permit re-assignment.

https://codereview.chromium.org/2003533002/diff/40001/chrome/browser/chromeos...
File chrome/browser/chromeos/arc/arc_downloads_watcher_service.h (right):

https://codereview.chromium.org/2003533002/diff/40001/chrome/browser/chromeos...
chrome/browser/chromeos/arc/arc_downloads_watcher_service.h:39: void
StartWatchDownloads();
On 2016/05/20 15:18:59, Luis Héctor Chávez (slow 5-23) wrote:
> nit: StartWatchingDownloads() or StartDownloadsWatch(). Same below.

Done.

[Luis Héctor Chávez, 2016-05-24 15:34:00]

This change LGTM but please update the commit message before submitting to point
to the correct .mojom change ( https://codereview.chromium.org/1996933002/ ),
because it currently points to itself.

[Shuhei Takahashi, 2016-05-25 06:47:43]

Description was changed from

==========
arc: Register media files to MediaProvider.

ArcDownloadsWatcherService will watch Downloads directory to:
- register newly created media files to MediaProvider,
- remove removed media files from MediaProvider.

mojom is added in this change:
https://codereview.chromium.org/2003533002/

Corresponding ARC changes: ag/1059173, ag/1058841, ag/1059172

BUG=b/28755411
TEST=Manually tested
==========

to

==========
arc: Register media files to MediaProvider.

ArcDownloadsWatcherService will watch Downloads directory to:
- register newly created media files to MediaProvider,
- remove removed media files from MediaProvider.

mojom is added in this change:
https://codereview.chromium.org/1996933002/

Corresponding ARC changes: ag/1059173, ag/1058841, ag/1059172

BUG=b/28755411
TEST=Manually tested
==========

[Shuhei Takahashi, 2016-05-25 06:47:57]

On 2016/05/24 15:34:00, Luis Héctor Chávez wrote:
> This change LGTM but please update the commit message before submitting to
point
> to the correct .mojom change ( https://codereview.chromium.org/1996933002/ ),
> because it currently points to itself.

Oops! Nice catch.

[Shuhei Takahashi, 2016-05-25 07:50:09]

The CQ bit was checked by nya@chromium.org

[commit-bot: I haz the power, 2016-05-25 07:50:27]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2003533002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2003533002/60001

[commit-bot: I haz the power, 2016-05-25 08:04:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-25 08:04:59]

Try jobs failed on following builders:
  chromeos_amd64-generic_chromium_compile_only_ng on tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...)
  linux_chromium_gn_chromeos_rel on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Shuhei Takahashi, 2016-05-25 09:01:56]

Hmm it seems I should have tested with GN. Now it should build...

[Shuhei Takahashi, 2016-05-25 09:02:01]

The CQ bit was checked by nya@chromium.org

[Shuhei Takahashi, 2016-05-25 09:02:02]

The patchset sent to the CQ was uploaded after l-g-t-m from
lhchavez@chromium.org
Link to the patchset: https://codereview.chromium.org/2003533002/#ps80001
(title: "Use size_t.")

[commit-bot: I haz the power, 2016-05-25 09:02:31]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2003533002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2003533002/80001

[commit-bot: I haz the power, 2016-05-25 10:37:49]

Description was changed from

==========
arc: Register media files to MediaProvider.

ArcDownloadsWatcherService will watch Downloads directory to:
- register newly created media files to MediaProvider,
- remove removed media files from MediaProvider.

mojom is added in this change:
https://codereview.chromium.org/1996933002/

Corresponding ARC changes: ag/1059173, ag/1058841, ag/1059172

BUG=b/28755411
TEST=Manually tested
==========

to

==========
arc: Register media files to MediaProvider.

ArcDownloadsWatcherService will watch Downloads directory to:
- register newly created media files to MediaProvider,
- remove removed media files from MediaProvider.

mojom is added in this change:
https://codereview.chromium.org/1996933002/

Corresponding ARC changes: ag/1059173, ag/1058841, ag/1059172

BUG=b/28755411
TEST=Manually tested
==========

[commit-bot: I haz the power, 2016-05-25 10:37:51]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-05-25 10:39:00]

Description was changed from

==========
arc: Register media files to MediaProvider.

ArcDownloadsWatcherService will watch Downloads directory to:
- register newly created media files to MediaProvider,
- remove removed media files from MediaProvider.

mojom is added in this change:
https://codereview.chromium.org/1996933002/

Corresponding ARC changes: ag/1059173, ag/1058841, ag/1059172

BUG=b/28755411
TEST=Manually tested
==========

to

==========
arc: Register media files to MediaProvider.

ArcDownloadsWatcherService will watch Downloads directory to:
- register newly created media files to MediaProvider,
- remove removed media files from MediaProvider.

mojom is added in this change:
https://codereview.chromium.org/1996933002/

Corresponding ARC changes: ag/1059173, ag/1058841, ag/1059172

BUG=b/28755411
TEST=Manually tested

Committed: https://crrev.com/77d98aa9bd1800410c21193a969c6f987cf63fe3
Cr-Commit-Position: refs/heads/master@{#395860}
==========

[commit-bot: I haz the power, 2016-05-25 10:39:01]

Patchset 5 (id:??) landed as
https://crrev.com/77d98aa9bd1800410c21193a969c6f987cf63fe3
Cr-Commit-Position: refs/heads/master@{#395860}