Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(203)

Issue 200353003: Mojo: Increase epsilon in tests. (Closed)

Created:
6 years, 9 months ago by viettrungluu
Modified:
6 years, 9 months ago
Reviewers:
sky
CC:
chromium-reviews, Aaron Boodman, darin (slow to review), viettrungluu+watch_chromium.org, ben+mojo_chromium.org, abarth-chromium
Visibility:
Public.

Description

Mojo: Increase epsilon in tests. Unfortunately, some things can't really be tested without small-ish timeouts. Unfortunately our bots are slow/heavily loaded. R=sky@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=257119

Patch Set 1 #

Total comments: 1

Patch Set 2 : fix comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M mojo/system/message_pipe_dispatcher_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M mojo/system/simple_dispatcher_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M mojo/system/waiter_list_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M mojo/system/waiter_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
viettrungluu
6 years, 9 months ago (2014-03-14 15:03:09 UTC) #1
sky
LGTM https://codereview.chromium.org/200353003/diff/1/mojo/system/message_pipe_dispatcher_unittest.cc File mojo/system/message_pipe_dispatcher_unittest.cc (right): https://codereview.chromium.org/200353003/diff/1/mojo/system/message_pipe_dispatcher_unittest.cc#newcode32 mojo/system/message_pipe_dispatcher_unittest.cc:32: const int64_t kEpsilonMicros = 30 * kMicrosPerMs; // ...
6 years, 9 months ago (2014-03-14 15:25:29 UTC) #2
viettrungluu
6 years, 9 months ago (2014-03-14 15:38:11 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r257119 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698