Issue 200353003: Mojo: Increase epsilon in tests.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 200353003: Mojo: Increase epsilon in tests. (Closed)

Created:
6 years, 9 months ago by viettrungluu

Modified:
6 years, 9 months ago

Reviewers:
sky

CC:
chromium-reviews, Aaron Boodman, darin (slow to review), viettrungluu+watch_chromium.org, ben+mojo_chromium.org, abarth-chromium

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Mojo: Increase epsilon in tests. Unfortunately, some things can't really be tested without small-ish timeouts. Unfortunately our bots are slow/heavily loaded. R=sky@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=257119

Patch Set 1 #

Total comments: 1

Patch Set 2 : fix comments #

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -4 lines)			Patch
M	mojo/system/message_pipe_dispatcher_unittest.cc	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	mojo/system/simple_dispatcher_unittest.cc	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	mojo/system/waiter_list_unittest.cc	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	mojo/system/waiter_unittest.cc	View	1	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

sky

LGTM https://codereview.chromium.org/200353003/diff/1/mojo/system/message_pipe_dispatcher_unittest.cc File mojo/system/message_pipe_dispatcher_unittest.cc (right): https://codereview.chromium.org/200353003/diff/1/mojo/system/message_pipe_dispatcher_unittest.cc#newcode32 mojo/system/message_pipe_dispatcher_unittest.cc:32: const int64_t kEpsilonMicros = 30 * kMicrosPerMs; // ...

6 years, 9 months ago (2014-03-14 15:25:29 UTC) #2

viettrungluu

6 years, 9 months ago (2014-03-14 15:38:11 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 manually as r257119 (presubmit successful).

Expand Messages | Collapse Messages