[build] Fix d8-for-Android builds

[build] Fix d8-for-Android builds

Committed: https://crrev.com/80b936ae0df4b81f0c00536b9e1ac96aec77b914
Cr-Commit-Position: refs/heads/master@{#36406}

[Jakob Kummerow, 2016-05-20 09:44:14]

jkummerow@chromium.org changed reviewers:
+ jarin@chromium.org

[Jakob Kummerow, 2016-05-20 09:44:15]

Make android_arm compile again!

PTAL.

https://codereview.chromium.org/2003513002/diff/1/Makefile.android
File Makefile.android (left):

https://codereview.chromium.org/2003513002/diff/1/Makefile.android#oldcode69
Makefile.android:69: AR="$(ANDROID_TOOLCHAIN)/ar" \
Dropping this line fixes:

/bin/sh:
/toolchains/arm-linux-androideabi-4.9/prebuilt/linux-x86_64/arm-linux-androideabi/bin/ar:
No such file or directory

https://codereview.chromium.org/2003513002/diff/1/Makefile.android
File Makefile.android (right):

https://codereview.chromium.org/2003513002/diff/1/Makefile.android#newcode78
Makefile.android:78: PYTHONPATH="$(shell
pwd)/tools/generate_shim_headers:$(shell pwd)/gypfiles:$(PYTHONPATH)" \
This fixes:

gyp: Error importing pymod_do_mainmodule (has_valgrind): No module named
has_valgrind

https://codereview.chromium.org/2003513002/diff/1/test/cctest/compiler/codege...
File test/cctest/compiler/codegen-tester.h (right):

https://codereview.chromium.org/2003513002/diff/1/test/cctest/compiler/codege...
test/cctest/compiler/codegen-tester.h:259: CHECK(index < 4);
This fixes:

.././test/cctest/compiler/codegen-tester.h:259:17: warning: comparison of
unsigned expression >= 0 is always true [-Wtype-limits]

[Jarin, 2016-05-20 10:04:53]

lgtm

https://codereview.chromium.org/2003513002/diff/1/Makefile.android
File Makefile.android (left):

https://codereview.chromium.org/2003513002/diff/1/Makefile.android#oldcode69
Makefile.android:69: AR="$(ANDROID_TOOLCHAIN)/ar" \
On 2016/05/20 09:44:15, Jakob wrote:
> Dropping this line fixes:
> 
> /bin/sh:
>
/toolchains/arm-linux-androideabi-4.9/prebuilt/linux-x86_64/arm-linux-androideabi/bin/ar:
> No such file or directory

So why do not need to compute the ANDROID_TOOLCHAIN variable above?

[Jakob Kummerow, 2016-05-20 11:34:46]

https://codereview.chromium.org/2003513002/diff/1/Makefile.android
File Makefile.android (left):

https://codereview.chromium.org/2003513002/diff/1/Makefile.android#oldcode69
Makefile.android:69: AR="$(ANDROID_TOOLCHAIN)/ar" \
On 2016/05/20 10:04:53, Jarin wrote:
> On 2016/05/20 09:44:15, Jakob wrote:
> > Dropping this line fixes:
> > 
> > /bin/sh:
> >
>
/toolchains/arm-linux-androideabi-4.9/prebuilt/linux-x86_64/arm-linux-androideabi/bin/ar:
> > No such file or directory
> 
> So why do not need to compute the ANDROID_TOOLCHAIN variable above?

Good point. Dropped.

[Jakob Kummerow, 2016-05-20 11:37:52]

The CQ bit was checked by jkummerow@chromium.org

[Jakob Kummerow, 2016-05-20 11:37:53]

The patchset sent to the CQ was uploaded after l-g-t-m from jarin@chromium.org
Link to the patchset: https://codereview.chromium.org/2003513002/#ps20001
(title: "drop unneeded definitions")

[commit-bot: I haz the power, 2016-05-20 11:38:01]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2003513002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2003513002/20001

[commit-bot: I haz the power, 2016-05-20 12:09:27]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-05-20 12:11:05]

Description was changed from

==========
[build] Fix d8-for-Android builds
==========

to

==========
[build] Fix d8-for-Android builds

Committed: https://crrev.com/80b936ae0df4b81f0c00536b9e1ac96aec77b914
Cr-Commit-Position: refs/heads/master@{#36406}
==========

[commit-bot: I haz the power, 2016-05-20 12:11:05]

Patchset 2 (id:??) landed as
https://crrev.com/80b936ae0df4b81f0c00536b9e1ac96aec77b914
Cr-Commit-Position: refs/heads/master@{#36406}