Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1811)

Unified Diff: net/android/javatests/src/org/chromium/net/NetworkChangeNotifierTest.java

Issue 2003503003: Add a null check in ConnectivityManagerDelegate.getNetworkState (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Added test Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/android/java/src/org/chromium/net/NetworkChangeNotifierAutoDetect.java ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/android/javatests/src/org/chromium/net/NetworkChangeNotifierTest.java
diff --git a/net/android/javatests/src/org/chromium/net/NetworkChangeNotifierTest.java b/net/android/javatests/src/org/chromium/net/NetworkChangeNotifierTest.java
index 90fa543d723aa54cfbfcec511d0664059a0a4ac9..359edb9e4ac52dde94232cb78b3fcb04268db45e 100644
--- a/net/android/javatests/src/org/chromium/net/NetworkChangeNotifierTest.java
+++ b/net/android/javatests/src/org/chromium/net/NetworkChangeNotifierTest.java
@@ -691,6 +691,14 @@ public class NetworkChangeNotifierTest extends InstrumentationTestCase {
ConnectivityManagerDelegate delegate =
new ConnectivityManagerDelegate(getInstrumentation().getTargetContext());
delegate.getNetworkState();
+
+ // getNetworkState doesn't crash upon invalid Network argument.
+ Network invalidNetwork = null;
pauljensen 2016/05/21 00:33:03 nit: instead of null, maybe you could use netIdToN
xunjieli 2016/05/23 13:05:54 Done.
+ NetworkState invalidNetworkState = delegate.getNetworkState(invalidNetwork);
+ assertFalse(invalidNetworkState.isConnected());
+ assertEquals(-1, invalidNetworkState.getNetworkType());
+ assertEquals(-1, invalidNetworkState.getNetworkSubType());
+
if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.LOLLIPOP) {
Network[] networks = delegate.getAllNetworksUnfiltered();
if (networks.length >= 1) {
« no previous file with comments | « net/android/java/src/org/chromium/net/NetworkChangeNotifierAutoDetect.java ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698