Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(962)

Issue 2003503002: Revert of [ESNext] Activate async/await for ClusterFuzz (Closed)

Created:
4 years, 7 months ago by Michael Hablich
Modified:
4 years, 7 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [ESNext] Activate async/await for ClusterFuzz (patchset #1 id:1 of https://codereview.chromium.org/1992173002/ ) Reason for revert: First CF feedback is in, reverting for now until the know bugs are fixed. Original issue's description: > [ESNext] Activate async/await for ClusterFuzz > > BUG=v8:4483 > R=neis@chromium.org,littledan@chromium.org,caitpotter88@gmail.com > LOG=N > > Committed: https://crrev.com/c57cadfa09fa493141bf43c1c7b898187a71da19 > Cr-Commit-Position: refs/heads/master@{#36362} TBR=littledan@chromium.org,caitpotter88@gmail.com,neis@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:4483 Committed: https://crrev.com/eb059498b2b2d05731b0dce648bdab801d3873fd Cr-Commit-Position: refs/heads/master@{#36397}

Patch Set 1 #

Patch Set 2 : fixed patch #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M src/flag-definitions.h View 1 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 13 (5 generated)
Michael Hablich
Created Revert of [ESNext] Activate async/await for ClusterFuzz
4 years, 7 months ago (2016-05-20 08:26:43 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2003503002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2003503002/1
4 years, 7 months ago (2016-05-20 08:26:47 UTC) #2
commit-bot: I haz the power
Failed to apply patch for src/flag-definitions.h: While running git apply --index -3 -p1; error: patch ...
4 years, 7 months ago (2016-05-20 08:26:55 UTC) #4
Michael Starzinger
LGTM.
4 years, 7 months ago (2016-05-20 08:27:51 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2003503002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2003503002/40001
4 years, 7 months ago (2016-05-20 08:54:05 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:40001)
4 years, 7 months ago (2016-05-20 08:54:20 UTC) #10
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/eb059498b2b2d05731b0dce648bdab801d3873fd Cr-Commit-Position: refs/heads/master@{#36397}
4 years, 7 months ago (2016-05-20 08:56:41 UTC) #12
Dan Ehrenberg
4 years, 6 months ago (2016-05-31 17:15:06 UTC) #13
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:40001) has been created in
https://codereview.chromium.org/2023003002/ by littledan@chromium.org.

The reason for reverting is: All known async/await issues are fixed; turn back
on Clusterfuzz.

Powered by Google App Engine
This is Rietveld 408576698