Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Issue 2003493003: Disable antialising for shapes with shape-rendering="optimizeSpeed" (Closed)

Created:
4 years, 7 months ago by pdr.
Modified:
4 years, 7 months ago
Reviewers:
fs
CC:
blink-reviews, blink-reviews-paint_chromium.org, chromium-reviews, dshwang, slimming-paint-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Disable antialising for shapes with shape-rendering="optimizeSpeed" The SVG spec hints that optimizeSpeed may disable antialising[1] and this matches Gecko's behavior. This patch disables shape anti-aliasing when optimizeSpeed is used. The shape rendering test has been improved to cover all shape-rendering values, and to include both stroked lines and filled paths. [1] https://svgwg.org/svg2-draft/single-page.html#painting-ShapeRendering BUG=603796 Committed: https://crrev.com/e04404cc853af2b6b91744e9d6d8a15403d1d426 Cr-Commit-Position: refs/heads/master@{#395272}

Patch Set 1 #

Patch Set 2 : Great expectations #

Unified diffs Side-by-side diffs Delta from patch set Stats (+78 lines, -17 lines) Patch
M third_party/WebKit/LayoutTests/TestExpectations View 1 1 chunk +3 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac/svg/custom/shape-rendering-expected.png View Binary file 0 comments Download
M third_party/WebKit/LayoutTests/svg/custom/shape-rendering.svg View 1 chunk +37 lines, -6 lines 0 comments Download
M third_party/WebKit/LayoutTests/svg/custom/shape-rendering-expected.txt View 1 chunk +37 lines, -10 lines 0 comments Download
M third_party/WebKit/Source/core/paint/SVGShapePainter.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 16 (7 generated)
pdr.
I hit this again wrestling with Firefox's antialising of a QR code... might as well ...
4 years, 7 months ago (2016-05-21 01:28:14 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2003493003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2003493003/1
4 years, 7 months ago (2016-05-21 01:28:43 UTC) #4
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/231959)
4 years, 7 months ago (2016-05-21 02:51:56 UTC) #6
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2003493003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2003493003/20001
4 years, 7 months ago (2016-05-21 03:00:05 UTC) #8
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/233398)
4 years, 7 months ago (2016-05-21 05:29:49 UTC) #10
fs
On 2016/05/21 at 01:28:14, pdr wrote: > I hit this again wrestling with Firefox's antialising ...
4 years, 7 months ago (2016-05-21 15:48:07 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2003493003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2003493003/20001
4 years, 7 months ago (2016-05-22 01:22:08 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 7 months ago (2016-05-22 04:49:05 UTC) #14
commit-bot: I haz the power
4 years, 7 months ago (2016-05-22 04:50:13 UTC) #16
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/e04404cc853af2b6b91744e9d6d8a15403d1d426
Cr-Commit-Position: refs/heads/master@{#395272}

Powered by Google App Engine
This is Rietveld 408576698