Refactor script position calculation

Refactor script position calculation

Script position calculation logic (i.e. line & column numbers for a
given code position) is now based on a single method
Script::GetPositionInfo(). Refactored related code in isolate.cc and
js/messages.js to use the new method. The line_ends accessor is still
in use by chromium and thus cannot be removed yet.

R=yangguo@chromium.org
BUG=

Committed: https://crrev.com/2f3879d54633c4076d38e9fc85b6e2e157c61548
Cr-Commit-Position: refs/heads/master@{#36398}

[jgruber1, 2016-05-20 07:36:18]

The CQ bit was checked by jgruber@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-05-20 07:36:25]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2003483002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2003483002/1

[jgruber, 2016-05-20 07:38:23]

Identical to https://codereview.chromium.org/1986173002 except changes to
bootstrapper.cc and accessors.{h,cc} have been reverted.

[Yang, 2016-05-20 07:41:00]

LGTM with nit

https://codereview.chromium.org/2003483002/diff/1/src/objects.h
File src/objects.h (right):

https://codereview.chromium.org/2003483002/diff/1/src/objects.h#newcode6452
src/objects.h:6452: enum OffsetFlag { kNoOffset = 0, kWithOffset = 1 };
nit: enum arguments are usually upper case, see for example
Compiler::ClearExceptionFlag

[commit-bot: I haz the power, 2016-05-20 08:09:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-20 08:09:40]

Dry run: This issue passed the CQ dry run.

[jgruber, 2016-05-20 08:19:06]

jgruber@chromium.org changed reviewers:
+ jgruber@chromium.org

[jgruber, 2016-05-20 08:19:07]

https://codereview.chromium.org/2003483002/diff/1/src/objects.h
File src/objects.h (right):

https://codereview.chromium.org/2003483002/diff/1/src/objects.h#newcode6452
src/objects.h:6452: enum OffsetFlag { kNoOffset = 0, kWithOffset = 1 };
On 2016/05/20 07:41:00, Yang wrote:
> nit: enum arguments are usually upper case, see for example
> Compiler::ClearExceptionFlag

Done.

[jgruber, 2016-05-20 08:19:14]

The CQ bit was checked by jgruber@chromium.org

[jgruber, 2016-05-20 08:19:14]

The patchset sent to the CQ was uploaded after l-g-t-m from yangguo@chromium.org
Link to the patchset: https://codereview.chromium.org/2003483002/#ps20001
(title: "Uppercase enums")

[commit-bot: I haz the power, 2016-05-20 08:19:17]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2003483002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2003483002/20001

[commit-bot: I haz the power, 2016-05-20 08:20:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-20 08:20:28]

Try jobs failed on following builders:
  v8_linux64_asan_rel_ng on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_asan_rel_ng/buil...)
  v8_linux64_avx2_rel_ng on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel_ng/buil...)
  v8_linux64_rel_ng on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_rel_ng/builds/6056)
  v8_linux_arm64_rel_ng on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm64_rel_ng/build...)
  v8_linux_gcc_compile_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_gcc_compile_rel/bu...)
  v8_linux_mipsel_compile_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_mipsel_compile_rel...)
  v8_linux_nodcheck_rel_ng on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_nodcheck_rel_ng/bu...)
  v8_linux_rel_ng on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_rel_ng/builds/6043)
  v8_presubmit on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/15630)

[jgruber, 2016-05-20 08:25:01]

The CQ bit was checked by jgruber@chromium.org

[jgruber, 2016-05-20 08:25:01]

The patchset sent to the CQ was uploaded after l-g-t-m from yangguo@chromium.org
Link to the patchset: https://codereview.chromium.org/2003483002/#ps40001
(title: "Attempt to fix branch dependencies")

[commit-bot: I haz the power, 2016-05-20 08:25:07]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2003483002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2003483002/40001

[commit-bot: I haz the power, 2016-05-20 08:59:05]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-05-20 09:00:26]

Description was changed from

==========
Refactor script position calculation

Script position calculation logic (i.e. line & column numbers for a
given code position) is now based on a single method
Script::GetPositionInfo(). Refactored related code in isolate.cc and
js/messages.js to use the new method. The line_ends accessor is still
in use by chromium and thus cannot be removed yet.

R=yangguo@chromium.org
BUG=
==========

to

==========
Refactor script position calculation

Script position calculation logic (i.e. line & column numbers for a
given code position) is now based on a single method
Script::GetPositionInfo(). Refactored related code in isolate.cc and
js/messages.js to use the new method. The line_ends accessor is still
in use by chromium and thus cannot be removed yet.

R=yangguo@chromium.org
BUG=

Committed: https://crrev.com/2f3879d54633c4076d38e9fc85b6e2e157c61548
Cr-Commit-Position: refs/heads/master@{#36398}
==========

[commit-bot: I haz the power, 2016-05-20 09:00:27]

Patchset 3 (id:??) landed as
https://crrev.com/2f3879d54633c4076d38e9fc85b6e2e157c61548
Cr-Commit-Position: refs/heads/master@{#36398}

[Michael Achenbach, 2016-05-20 10:48:39]

A revert of this CL (patchset #3 id:40001) has been created in
https://codereview.chromium.org/1995323002/ by machenbach@chromium.org.

The reason for reverting is: Crashes gc stress with custom snapshot:
https://build.chromium.org/p/client.v8/builders/V8%20Linux64%20GC%20Stress%20....